fix: update failing tests for HorizonStakingNotAuthorized (OZ_N-05)

Author: MoonBoi9001

packages/horizon/test/staking/provision/deprovision.t.sol

@@ -75,9 +75,9 @@ contract HorizonStakingDeprovisionTest is HorizonStakingTest {
         vm.startPrank(users.operator);
         bytes memory expectedError = abi.encodeWithSignature(
             "HorizonStakingNotAuthorized(address,address,address)",
-            users.indexer,
+            subgraphDataServiceAddress,
             users.operator,
-            subgraphDataServiceAddress
+            users.indexer
         );
         vm.expectRevert(expectedError);
         staking.deprovision(users.indexer, subgraphDataServiceAddress, 0);

packages/horizon/test/staking/provision/locked.t.sol

@@ -66,9 +66,9 @@ contract HorizonStakingProvisionLockedTest is HorizonStakingTest {
         vm.startPrank(users.operator);
         bytes memory expectedError = abi.encodeWithSignature(
             "HorizonStakingNotAuthorized(address,address,address)",
-            users.indexer,
+            subgraphDataServiceAddress,
             users.operator,
-            subgraphDataServiceAddress
+            users.indexer
         );
         vm.expectRevert(expectedError);
         staking.provisionLocked(

packages/horizon/test/staking/provision/parameters.t.sol

@@ -42,9 +42,9 @@ contract HorizonStakingProvisionParametersTest is HorizonStakingTest {
         vm.expectRevert(
             abi.encodeWithSignature(
                 "HorizonStakingNotAuthorized(address,address,address)",
-                users.indexer,
+                subgraphDataServiceAddress,
                 msg.sender,
-                subgraphDataServiceAddress
+                users.indexer
             )
         );
         staking.setProvisionParameters(users.indexer, subgraphDataServiceAddress, maxVerifierCut, thawingPeriod);

packages/horizon/test/staking/provision/provision.t.sol

@@ -102,9 +102,9 @@ contract HorizonStakingProvisionTest is HorizonStakingTest {
         vm.startPrank(users.operator);
         bytes memory expectedError = abi.encodeWithSignature(
             "HorizonStakingNotAuthorized(address,address,address)",
-            users.indexer,
+            subgraphDataServiceAddress,
             users.operator,
-            subgraphDataServiceAddress
+            users.indexer,
         );
         vm.expectRevert(expectedError);
         staking.provision(users.indexer, subgraphDataServiceAddress, amount, maxVerifierCut, thawingPeriod);

packages/horizon/test/staking/provision/reprovision.t.sol

@@ -80,9 +80,9 @@ contract HorizonStakingReprovisionTest is HorizonStakingTest {
         vm.startPrank(users.operator);
         bytes memory expectedError = abi.encodeWithSignature(
             "HorizonStakingNotAuthorized(address,address,address)",
-            users.indexer,
+            newDataService,
             users.operator,
-            newDataService
+            users.indexer
         );
         vm.expectRevert(expectedError);
         staking.reprovision(users.indexer, subgraphDataServiceAddress, newDataService, provisionAmount, 0);

packages/horizon/test/staking/provision/thaw.t.sol

@@ -49,9 +49,9 @@ contract HorizonStakingThawTest is HorizonStakingTest {
         vm.startPrank(users.operator);
         bytes memory expectedError = abi.encodeWithSignature(
             "HorizonStakingNotAuthorized(address,address,address)",
-            users.indexer,
+            subgraphDataServiceAddress,
             users.operator,
-            subgraphDataServiceAddress
+            users.indexer
         );
         vm.expectRevert(expectedError);
         staking.thaw(users.indexer, subgraphDataServiceAddress, amount);