chore: fix linting issues

Signed-off-by: Tomás Migone <[email protected]>

Author: tmigone

packages/horizon/contracts/data-service/DataService.sol

@@ -35,21 +35,6 @@ abstract contract DataService is GraphDirectory, ProvisionManager, DataServiceV1
      */
     constructor(address controller) GraphDirectory(controller) {}
 
-    /**
-     * @notice Initializes the contract and any parent contracts.
-     */
-    // solhint-disable-next-line func-name-mixedcase
-    function __DataService_init() internal onlyInitializing {
-        __ProvisionManager_init_unchained();
-        __DataService_init_unchained();
-    }
-
-    /**
-     * @notice Initializes the contract.
-     */
-    // solhint-disable-next-line func-name-mixedcase
-    function __DataService_init_unchained() internal onlyInitializing {}
-
     /**
      * @notice See {IDataService-getThawingPeriodRange}.
      */
@@ -77,4 +62,19 @@ abstract contract DataService is GraphDirectory, ProvisionManager, DataServiceV1
     function getDelegationRatio() external view returns (uint32) {
         return _getDelegationRatio();
     }
+
+    /**
+     * @notice Initializes the contract and any parent contracts.
+     */
+    // solhint-disable-next-line func-name-mixedcase
+    function __DataService_init() internal onlyInitializing {
+        __ProvisionManager_init_unchained();
+        __DataService_init_unchained();
+    }
+
+    /**
+     * @notice Initializes the contract.
+     */
+    // solhint-disable-next-line func-name-mixedcase
+    function __DataService_init_unchained() internal onlyInitializing {}
 }

packages/horizon/contracts/interfaces/ITAPCollector.sol

@@ -239,20 +239,6 @@ interface ITAPCollector is IPaymentsCollector {
      */
     function revokeAuthorizedSigner(address signer) external;
 
-    /**
-     * @dev Recovers the signer address of a signed ReceiptAggregateVoucher (RAV).
-     * @param signedRAV The SignedRAV containing the RAV and its signature.
-     * @return The address of the signer.
-     */
-    function recoverRAVSigner(SignedRAV calldata signedRAV) external view returns (address);
-
-    /**
-     * @dev Computes the hash of a ReceiptAggregateVoucher (RAV).
-     * @param rav The RAV for which to compute the hash.
-     * @return The hash of the RAV.
-     */
-    function encodeRAV(ReceiptAggregateVoucher calldata rav) external view returns (bytes32);
-
     /**
      * @notice See {IPaymentsCollector.collect}
      * This variant adds the ability to partially collect a RAV by specifying the amount of tokens to collect.
@@ -269,4 +255,18 @@ interface ITAPCollector is IPaymentsCollector {
         bytes calldata data,
         uint256 tokensToCollect
     ) external returns (uint256);
+
+    /**
+     * @dev Recovers the signer address of a signed ReceiptAggregateVoucher (RAV).
+     * @param signedRAV The SignedRAV containing the RAV and its signature.
+     * @return The address of the signer.
+     */
+    function recoverRAVSigner(SignedRAV calldata signedRAV) external view returns (address);
+
+    /**
+     * @dev Computes the hash of a ReceiptAggregateVoucher (RAV).
+     * @param rav The RAV for which to compute the hash.
+     * @return The hash of the RAV.
+     */
+    function encodeRAV(ReceiptAggregateVoucher calldata rav) external view returns (bytes32);
 }

packages/horizon/contracts/interfaces/internal/IHorizonStakingExtension.sol

@@ -105,6 +105,16 @@ interface IHorizonStakingExtension is IRewardsIssuer {
      */
     function collect(uint256 tokens, address allocationID) external;
 
+    /**
+     * @notice Slash the indexer stake. Delegated tokens are not subject to slashing.
+     * @dev Can only be called by the slasher role.
+     * @param indexer Address of indexer to slash
+     * @param tokens Amount of tokens to slash from the indexer stake
+     * @param reward Amount of reward tokens to send to a beneficiary
+     * @param beneficiary Address of a beneficiary to receive a reward for the slashing
+     */
+    function legacySlash(address indexer, uint256 tokens, uint256 reward, address beneficiary) external;
+
     /**
      * @notice Return true if operator is allowed for indexer.
      * @param operator Address of the operator
@@ -154,14 +164,4 @@ interface IHorizonStakingExtension is IRewardsIssuer {
      */
     // solhint-disable-next-line func-name-mixedcase
     function __DEPRECATED_getThawingPeriod() external view returns (uint64);
-
-    /**
-     * @notice Slash the indexer stake. Delegated tokens are not subject to slashing.
-     * @dev Can only be called by the slasher role.
-     * @param indexer Address of indexer to slash
-     * @param tokens Amount of tokens to slash from the indexer stake
-     * @param reward Amount of reward tokens to send to a beneficiary
-     * @param beneficiary Address of a beneficiary to receive a reward for the slashing
-     */
-    function legacySlash(address indexer, uint256 tokens, uint256 reward, address beneficiary) external;
 }

packages/horizon/contracts/staking/HorizonStaking.sol

@@ -430,6 +430,7 @@ contract HorizonStaking is HorizonStakingBase, IHorizonStakingMain {
         // Check if sender is authorized to slash on the deprecated list
         if (__DEPRECATED_slashers[msg.sender]) {
             // Forward call to staking extension
+            // solhint-disable-next-line avoid-low-level-calls
             (bool success, ) = STAKING_EXTENSION_ADDRESS.delegatecall(
                 abi.encodeWithSelector(
                     IHorizonStakingExtension.legacySlash.selector,
@@ -439,7 +440,7 @@ contract HorizonStaking is HorizonStakingBase, IHorizonStakingMain {
                     verifierDestination
                 )
             );
-            require(success, "Delegatecall to legacySlash failed");
+            require(success, "Delegatecall: legacySlash failed");
             return;
         }
 
@@ -1032,60 +1033,62 @@ contract HorizonStaking is HorizonStakingBase, IHorizonStakingMain {
     /**
      * @notice Traverses a thaw request list and fulfills expired thaw requests.
      * @dev Emits a {ThawRequestsFulfilled} event and a {ThawRequestFulfilled} event for each thaw request fulfilled.
-     * @param params The parameters for fulfilling thaw requests
+     * @param _params The parameters for fulfilling thaw requests
      * @return The amount of thawed tokens
      * @return The amount of tokens still thawing
      * @return The amount of shares still thawing
      */
-    function _fulfillThawRequests(FulfillThawRequestsParams memory params) private returns (uint256, uint256, uint256) {
+    function _fulfillThawRequests(
+        FulfillThawRequestsParams memory _params
+    ) private returns (uint256, uint256, uint256) {
         LinkedList.List storage thawRequestList = _getThawRequestList(
-            params.requestType,
-            params.serviceProvider,
-            params.verifier,
-            params.owner
+            _params.requestType,
+            _params.serviceProvider,
+            _params.verifier,
+            _params.owner
         );
         require(thawRequestList.count > 0, HorizonStakingNothingThawing());
 
-        TraverseThawRequestsResults memory results = _traverseThawRequests(params, thawRequestList);
+        TraverseThawRequestsResults memory results = _traverseThawRequests(_params, thawRequestList);
 
         emit ThawRequestsFulfilled(
-            params.serviceProvider,
-            params.verifier,
-            params.owner,
+            _params.serviceProvider,
+            _params.verifier,
+            _params.owner,
             results.requestsFulfilled,
             results.tokensThawed,
-            params.requestType
+            _params.requestType
         );
 
         return (results.tokensThawed, results.tokensThawing, results.sharesThawing);
     }
 
     /**
      * @notice Traverses a thaw request list and fulfills expired thaw requests.
-     * @param params The parameters for fulfilling thaw requests
-     * @param thawRequestList The list of thaw requests to traverse
+     * @param _params The parameters for fulfilling thaw requests
+     * @param _thawRequestList The list of thaw requests to traverse
      * @return The results of the traversal
      */
     function _traverseThawRequests(
-        FulfillThawRequestsParams memory params,
-        LinkedList.List storage thawRequestList
+        FulfillThawRequestsParams memory _params,
+        LinkedList.List storage _thawRequestList
     ) private returns (TraverseThawRequestsResults memory) {
-        function(bytes32) view returns (bytes32) getNextItem = _getNextThawRequest(params.requestType);
-        function(bytes32) deleteItem = _getDeleteThawRequest(params.requestType);
+        function(bytes32) view returns (bytes32) getNextItem = _getNextThawRequest(_params.requestType);
+        function(bytes32) deleteItem = _getDeleteThawRequest(_params.requestType);
 
         bytes memory acc = abi.encode(
-            params.requestType,
+            _params.requestType,
             uint256(0),
-            params.tokensThawing,
-            params.sharesThawing,
-            params.thawingNonce
+            _params.tokensThawing,
+            _params.sharesThawing,
+            _params.thawingNonce
         );
-        (uint256 thawRequestsFulfilled, bytes memory data) = thawRequestList.traverse(
+        (uint256 thawRequestsFulfilled, bytes memory data) = _thawRequestList.traverse(
             getNextItem,
             _fulfillThawRequest,
             deleteItem,
             acc,
-            params.nThawRequests
+            _params.nThawRequests
         );
 
         (, uint256 tokensThawed, uint256 tokensThawing, uint256 sharesThawing) = abi.decode(
@@ -1152,21 +1155,6 @@ contract HorizonStaking is HorizonStakingBase, IHorizonStakingMain {
         return (false, _acc);
     }
 
-    /**
-     * @notice Determines the correct callback function for `deleteItem` based on the request type.
-     * @param _requestType The type of thaw request (Provision or Delegation).
-     * @return A function pointer to the appropriate `deleteItem` callback.
-     */
-    function _getDeleteThawRequest(ThawRequestType _requestType) private pure returns (function(bytes32)) {
-        if (_requestType == ThawRequestType.Provision) {
-            return _deleteProvisionThawRequest;
-        } else if (_requestType == ThawRequestType.Delegation) {
-            return _deleteDelegationThawRequest;
-        } else {
-            revert HorizonStakingInvalidThawRequestType();
-        }
-    }
-
     /**
      * @notice Deletes a thaw request for a provision.
      * @param _thawRequestId The ID of the thaw request to delete.
@@ -1213,4 +1201,19 @@ contract HorizonStaking is HorizonStakingBase, IHorizonStakingMain {
             return _operatorAuth[_serviceProvider][_verifier][_operator];
         }
     }
+
+    /**
+     * @notice Determines the correct callback function for `deleteItem` based on the request type.
+     * @param _requestType The type of thaw request (Provision or Delegation).
+     * @return A function pointer to the appropriate `deleteItem` callback.
+     */
+    function _getDeleteThawRequest(ThawRequestType _requestType) private pure returns (function(bytes32)) {
+        if (_requestType == ThawRequestType.Provision) {
+            return _deleteProvisionThawRequest;
+        } else if (_requestType == ThawRequestType.Delegation) {
+            return _deleteDelegationThawRequest;
+        } else {
+            revert HorizonStakingInvalidThawRequestType();
+        }
+    }
 }

packages/horizon/contracts/staking/HorizonStakingBase.sol

@@ -298,23 +298,6 @@ abstract contract HorizonStakingBase is
         return _provisions[_serviceProvider][_verifier].tokens - _provisions[_serviceProvider][_verifier].tokensThawing;
     }
 
-    /**
-     * @notice Determines the correct callback function for `getNextItem` based on the request type.
-     * @param _requestType The type of thaw request (Provision or Delegation).
-     * @return A function pointer to the appropriate `getNextItem` callback.
-     */
-    function _getNextThawRequest(
-        ThawRequestType _requestType
-    ) internal pure returns (function(bytes32) view returns (bytes32)) {
-        if (_requestType == ThawRequestType.Provision) {
-            return _getNextProvisionThawRequest;
-        } else if (_requestType == ThawRequestType.Delegation) {
-            return _getNextDelegationThawRequest;
-        } else {
-            revert HorizonStakingInvalidThawRequestType();
-        }
-    }
-
     /**
      * @notice Retrieves the next thaw request for a provision.
      * @param _thawRequestId The ID of the current thaw request.
@@ -367,6 +350,23 @@ abstract contract HorizonStakingBase is
         return _thawRequests[_requestType][_thawRequestId];
     }
 
+    /**
+     * @notice Determines the correct callback function for `getNextItem` based on the request type.
+     * @param _requestType The type of thaw request (Provision or Delegation).
+     * @return A function pointer to the appropriate `getNextItem` callback.
+     */
+    function _getNextThawRequest(
+        ThawRequestType _requestType
+    ) internal pure returns (function(bytes32) view returns (bytes32)) {
+        if (_requestType == ThawRequestType.Provision) {
+            return _getNextProvisionThawRequest;
+        } else if (_requestType == ThawRequestType.Delegation) {
+            return _getNextDelegationThawRequest;
+        } else {
+            revert HorizonStakingInvalidThawRequestType();
+        }
+    }
+
     /**
      * @notice See {IHorizonStakingBase-getDelegatedTokensAvailable}.
      */