Skip to content

Commit 38fa468

Browse files
committed
fix: mark some non-deployable contracts as abstract (C4 QA)
1 parent cc78a5c commit 38fa468

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

contracts/governance/Governed.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ pragma solidity ^0.7.6;
66
* @title Graph Governance contract
77
* @dev All contracts that will be owned by a Governor entity should extend this contract.
88
*/
9-
contract Governed {
9+
abstract contract Governed {
1010
// -- State --
1111

1212
/// Address of the governor

contracts/governance/Managed.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import "./IManaged.sol";
2222
* Inspired by Livepeer:
2323
* https://github.com/livepeer/protocol/blob/streamflow/contracts/Controller.sol
2424
*/
25-
contract Managed is IManaged {
25+
abstract contract Managed is IManaged {
2626
// -- State --
2727

2828
/// Controller that contract is registered with

contracts/governance/Pausable.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
pragma solidity ^0.7.6;
44

5-
contract Pausable {
5+
abstract contract Pausable {
66
/**
77
* @dev "Partial paused" pauses exit and enter functions for GRT, but not internal
88
* functions, such as allocating

contracts/l2/token/GraphTokenUpgradeable.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import "../../governance/Governed.sol";
2424
* initializer functions and upgradeable OpenZeppelin contracts instead of
2525
* the original's constructor + non-upgradeable approach.
2626
*/
27-
contract GraphTokenUpgradeable is GraphUpgradeable, Governed, ERC20BurnableUpgradeable {
27+
abstract contract GraphTokenUpgradeable is GraphUpgradeable, Governed, ERC20BurnableUpgradeable {
2828
// -- EIP712 --
2929
// https://github.com/ethereum/EIPs/blob/master/EIPS/eip-712.md#definition-of-domainseparator
3030

contracts/upgrades/GraphProxyStorage.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ pragma solidity ^0.7.6;
88
* This contract does not actually define state variables managed by the compiler
99
* but uses fixed slot locations.
1010
*/
11-
contract GraphProxyStorage {
11+
abstract contract GraphProxyStorage {
1212
/**
1313
* @dev Storage slot with the address of the current implementation.
1414
* This is the keccak-256 hash of "eip1967.proxy.implementation" subtracted by 1, and is

contracts/upgrades/GraphUpgradeable.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import "./IGraphProxy.sol";
88
* @title Graph Upgradeable
99
* @dev This contract is intended to be inherited from upgradeable contracts.
1010
*/
11-
contract GraphUpgradeable {
11+
abstract contract GraphUpgradeable {
1212
/**
1313
* @dev Storage slot with the address of the current implementation.
1414
* This is the keccak-256 hash of "eip1967.proxy.implementation" subtracted by 1, and is

0 commit comments

Comments
 (0)