fix: add storage gap to upgradeable contract (TRST-R04)

tmigone · tmigone · commit 5c835628ff78 · 2024-12-04T10:24:49.000-03:00
Signed-off-by: Tomás Migone &lt;tomas@edgeandnode.com&gt;
diff --git a/packages/horizon/contracts/data-service/extensions/DataServiceFeesStorage.sol b/packages/horizon/contracts/data-service/extensions/DataServiceFeesStorage.sol
@@ -18,5 +18,6 @@ abstract contract DataServiceFeesV1Storage {
     mapping(address serviceProvider => LinkedList.List list) public claimsLists;
 
     /// @dev Gap to allow adding variables in future upgrades
+    /// Note that this contract is not upgradeable but might be inherited by an upgradeable contract
     uint256[50] private __gap;
 }
diff --git a/packages/horizon/contracts/data-service/extensions/DataServicePausableUpgradeable.sol b/packages/horizon/contracts/data-service/extensions/DataServicePausableUpgradeable.sol
@@ -15,6 +15,9 @@ abstract contract DataServicePausableUpgradeable is PausableUpgradeable, DataSer
     /// @notice List of pause guardians and their allowed status
     mapping(address pauseGuardian => bool allowed) public pauseGuardians;
 
+    /// @dev Gap to allow adding variables in future upgrades
+    uint256[50] private __gap;
+
     /**
      * @notice Checks if the caller is a pause guardian.
      */

Original file line number	Diff line number	Diff line change
`@@ -18,5 +18,6 @@ abstract contract DataServiceFeesV1Storage {`
`18`	`18`	`mapping(address serviceProvider => LinkedList.List list) public claimsLists;`
`19`	`19`
`20`	`20`	`/// @dev Gap to allow adding variables in future upgrades`
	`21`	`+ /// Note that this contract is not upgradeable but might be inherited by an upgradeable contract`
`21`	`22`	`uint256[50] private __gap;`
`22`	`23`	`}`