fix: emit the correct old admin in _setAdmin (C4 QA)

pcarranzav · pcarranzav · commit 751240dcbdf8 · 2022-10-28T17:36:32.000-03:00
diff --git a/contracts/upgrades/GraphProxyStorage.sol b/contracts/upgrades/GraphProxyStorage.sol
@@ -79,13 +79,14 @@ contract GraphProxyStorage {
      * @param _newAdmin Address of the new proxy admin
      */
     function _setAdmin(address _newAdmin) internal {
+        address oldAdmin = _getAdmin();
         bytes32 slot = ADMIN_SLOT;
         // solhint-disable-next-line no-inline-assembly
         assembly {
             sstore(slot, _newAdmin)
         }
 
-        emit AdminUpdated(_getAdmin(), _newAdmin);
+        emit AdminUpdated(oldAdmin, _newAdmin);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -79,13 +79,14 @@ contract GraphProxyStorage {`
`79`	`79`	`* @param _newAdmin Address of the new proxy admin`
`80`	`80`	`*/`
`81`	`81`	`function _setAdmin(address _newAdmin) internal {`
	`82`	`+ address oldAdmin = _getAdmin();`
`82`	`83`	`bytes32 slot = ADMIN_SLOT;`
`83`	`84`	`// solhint-disable-next-line no-inline-assembly`
`84`	`85`	`assembly {`
`85`	`86`	`sstore(slot, _newAdmin)`
`86`	`87`	`}`
`87`	`88`
`88`		`- emit AdminUpdated(_getAdmin(), _newAdmin);`
	`89`	`+ emit AdminUpdated(oldAdmin, _newAdmin);`
`89`	`90`	`}`
`90`	`91`
`91`	`92`	`/**`