fix(c4-172-g02): set allowance to 0 instead of decreasing allowance by approved amount

tmigone · tmigone · commit 7d29d6d57892 · 2022-10-27T12:07:19.000-03:00
Signed-off-by: Tomás Migone &lt;tomas@edgeandnode.com&gt;
diff --git a/contracts/gateway/BridgeEscrow.sol b/contracts/gateway/BridgeEscrow.sol
@@ -36,7 +36,6 @@ contract BridgeEscrow is Initializable, GraphUpgradeable, Managed {
      * @param _spender Address of the spender that will be revoked
      */
     function revokeAll(address _spender) external onlyGovernor {
-        IGraphToken grt = graphToken();
-        grt.decreaseAllowance(_spender, grt.allowance(address(this), _spender));
+        graphToken().approve(_spender, 0);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,6 @@ contract BridgeEscrow is Initializable, GraphUpgradeable, Managed {`
`36`	`36`	`* @param _spender Address of the spender that will be revoked`
`37`	`37`	`*/`
`38`	`38`	`function revokeAll(address _spender) external onlyGovernor {`
`39`		`- IGraphToken grt = graphToken();`
`40`		`- grt.decreaseAllowance(_spender, grt.allowance(address(this), _spender));`
	`39`	`+ graphToken().approve(_spender, 0);`
`41`	`40`	`}`
`42`	`41`	`}`