fix: add Horizon prefix to stake events

Author: Maikol

packages/horizon/contracts/interfaces/internal/IHorizonStakingBase.sol

@@ -22,7 +22,7 @@ interface IHorizonStakingBase {
      * @param serviceProvider The address of the service provider.
      * @param tokens The amount of tokens staked.
      */
-    event StakeDeposited(address indexed serviceProvider, uint256 tokens);
+    event HorizonStakeDeposited(address indexed serviceProvider, uint256 tokens);
 
     /**
      * @notice Thrown when using an invalid thaw request type.

packages/horizon/contracts/interfaces/internal/IHorizonStakingMain.sol

@@ -24,14 +24,14 @@ interface IHorizonStakingMain {
      * @param tokens The amount of tokens unstaked
      * @param until The block number until the stake is locked
      */
-    event StakeLocked(address indexed serviceProvider, uint256 tokens, uint256 until);
+    event HorizonStakeLocked(address indexed serviceProvider, uint256 tokens, uint256 until);
 
     /**
      * @notice Emitted when a service provider withdraws tokens during the transition period.
      * @param serviceProvider The address of the service provider
      * @param tokens The amount of tokens withdrawn
      */
-    event StakeWithdrawn(address indexed serviceProvider, uint256 tokens);
+    event HorizonStakeWithdrawn(address indexed serviceProvider, uint256 tokens);
 
     // -- Events: provision --
 
@@ -486,7 +486,7 @@ interface IHorizonStakingMain {
      * - `_tokens` cannot be zero.
      * - Caller must have previously approved this contract to pull tokens from their balance.
      *
-     * Emits a {StakeDeposited} event.
+     * Emits a {HorizonStakeDeposited} event.
      *
      * @param tokens Amount of tokens to stake
      */
@@ -500,7 +500,7 @@ interface IHorizonStakingMain {
      * - `_tokens` cannot be zero.
      * - Caller must have previously approved this contract to pull tokens from their balance.
      *
-     * Emits a {StakeDeposited} event.
+     * Emits a {HorizonStakeDeposited} event.
      *
      * @param serviceProvider Address of the service provider
      * @param tokens Amount of tokens to stake
@@ -516,7 +516,7 @@ interface IHorizonStakingMain {
      * - `_tokens` cannot be zero.
      * - Caller must have previously approved this contract to pull tokens from their balance.
      *
-     * Emits {StakeDeposited} and {ProvisionIncreased} events.
+     * Emits {HorizonStakeDeposited} and {ProvisionIncreased} events.
      *
      * @param serviceProvider Address of the service provider
      * @param verifier Address of the verifier
@@ -537,8 +537,8 @@ interface IHorizonStakingMain {
      * - `_serviceProvider` must have enough idle stake to cover the staking amount and any
      *   legacy allocation.
      *
-     * Emits a {StakeLocked} event during the transition period.
-     * Emits a {StakeWithdrawn} event after the transition period.
+     * Emits a {HorizonStakeLocked} event during the transition period.
+     * Emits a {HorizonStakeWithdrawn} event after the transition period.
      *
      * @param tokens Amount of tokens to unstake
      */

packages/horizon/contracts/staking/HorizonStaking.sol

@@ -652,7 +652,7 @@ contract HorizonStaking is HorizonStakingBase, IHorizonStakingMain {
         if (lockingPeriod == 0) {
             sp.tokensStaked = stakedTokens - _tokens;
             _graphToken().pushTokens(serviceProvider, _tokens);
-            emit StakeWithdrawn(serviceProvider, _tokens);
+            emit HorizonStakeWithdrawn(serviceProvider, _tokens);
         } else {
             // Before locking more tokens, withdraw any unlocked ones if possible
             if (sp.__DEPRECATED_tokensLocked != 0 && block.number >= sp.__DEPRECATED_tokensLockedUntil) {
@@ -672,7 +672,7 @@ contract HorizonStaking is HorizonStakingBase, IHorizonStakingMain {
             // Update balances
             sp.__DEPRECATED_tokensLocked = sp.__DEPRECATED_tokensLocked + _tokens;
             sp.__DEPRECATED_tokensLockedUntil = block.number + lockingPeriod;
-            emit StakeLocked(serviceProvider, sp.__DEPRECATED_tokensLocked, sp.__DEPRECATED_tokensLockedUntil);
+            emit HorizonStakeLocked(serviceProvider, sp.__DEPRECATED_tokensLocked, sp.__DEPRECATED_tokensLockedUntil);
         }
     }
 
@@ -699,7 +699,7 @@ contract HorizonStaking is HorizonStakingBase, IHorizonStakingMain {
         // Return tokens to the service provider
         _graphToken().pushTokens(_serviceProvider, tokensToWithdraw);
 
-        emit StakeWithdrawn(_serviceProvider, tokensToWithdraw);
+        emit HorizonStakeWithdrawn(_serviceProvider, tokensToWithdraw);
     }
 
     /**

packages/horizon/contracts/staking/HorizonStakingBase.sol

@@ -253,13 +253,13 @@ abstract contract HorizonStakingBase is
      * @dev TODO: After transition period move to IHorizonStakingMain. Temporarily it
      * needs to be here since it's used by both {HorizonStaking} and {HorizonStakingExtension}.
      *
-     * Emits a {StakeDeposited} event.
+     * Emits a {HorizonStakeDeposited} event.
      * @param _serviceProvider The address of the service provider.
      * @param _tokens The amount of tokens to deposit.
      */
     function _stake(address _serviceProvider, uint256 _tokens) internal {
         _serviceProviders[_serviceProvider].tokensStaked = _serviceProviders[_serviceProvider].tokensStaked + _tokens;
-        emit StakeDeposited(_serviceProvider, _tokens);
+        emit HorizonStakeDeposited(_serviceProvider, _tokens);
     }
 
     /**

packages/horizon/test/shared/horizon-staking/HorizonStakingShared.t.sol

@@ -160,7 +160,7 @@ abstract contract HorizonStakingSharedTest is GraphBaseTest {
         // stakeTo
         token.approve(address(staking), tokens);
         vm.expectEmit();
-        emit IHorizonStakingBase.StakeDeposited(serviceProvider, tokens);
+        emit IHorizonStakingBase.HorizonStakeDeposited(serviceProvider, tokens);
         staking.stakeTo(serviceProvider, tokens);
 
         // after
@@ -209,15 +209,15 @@ abstract contract HorizonStakingSharedTest is GraphBaseTest {
         // unstake
         if (deprecatedThawingPeriod == 0) {
             vm.expectEmit(address(staking));
-            emit IHorizonStakingMain.StakeWithdrawn(msgSender, _tokens);
+            emit IHorizonStakingMain.HorizonStakeWithdrawn(msgSender, _tokens);
         } else {
             if (withdrawCalled) {
                 vm.expectEmit(address(staking));
-                emit IHorizonStakingMain.StakeWithdrawn(msgSender, beforeServiceProvider.__DEPRECATED_tokensLocked);
+                emit IHorizonStakingMain.HorizonStakeWithdrawn(msgSender, beforeServiceProvider.__DEPRECATED_tokensLocked);
             }
 
             vm.expectEmit(address(staking));
-            emit IHorizonStakingMain.StakeLocked(
+            emit IHorizonStakingMain.HorizonStakeLocked(
                 msgSender,
                 withdrawCalled ? _tokens : beforeServiceProvider.__DEPRECATED_tokensLocked + _tokens,
                 block.number + deprecatedThawingPeriod
@@ -278,7 +278,7 @@ abstract contract HorizonStakingSharedTest is GraphBaseTest {
 
         // withdraw
         vm.expectEmit(address(staking));
-        emit IHorizonStakingMain.StakeWithdrawn(msgSender, beforeServiceProvider.__DEPRECATED_tokensLocked);
+        emit IHorizonStakingMain.HorizonStakeWithdrawn(msgSender, beforeServiceProvider.__DEPRECATED_tokensLocked);
         staking.withdraw();
 
         // after