f: revert Allocation vis changes

Author: matiasedgeandnode

packages/subgraph-service/contracts/libraries/Allocation.sol

@@ -76,7 +76,7 @@ library Allocation {
         uint256 tokens,
         uint256 accRewardsPerAllocatedToken,
         uint256 createdAtEpoch
-    ) external returns (State memory) {
+    ) internal returns (State memory) {
         require(!self[allocationId].exists(), AllocationAlreadyExists(allocationId));
 
         State memory allocation = State({
@@ -104,54 +104,54 @@ library Allocation {
      * @param self The allocation list mapping
      * @param allocationId The allocation id
      */
-    function presentPOI(mapping(address => State) storage self, address allocationId) external {
+    function presentPOI(mapping(address => State) storage self, address allocationId) internal {
         State storage allocation = _get(self, allocationId);
         require(allocation.isOpen(), AllocationClosed(allocationId, allocation.closedAt));
         allocation.lastPOIPresentedAt = block.timestamp;
     }
 
     /**
-     * @notice Update the accumulated rewards pending to be claimed for an allocation
+     * @notice Update the accumulated rewards per allocated token for an allocation
      * @dev Requirements:
      * - The allocation must be open
      * @param self The allocation list mapping
      * @param allocationId The allocation id
+     * @param accRewardsPerAllocatedToken The new accumulated rewards per allocated token
      */
-    function clearPendingRewards(mapping(address => State) storage self, address allocationId) external {
+    function snapshotRewards(
+        mapping(address => State) storage self,
+        address allocationId,
+        uint256 accRewardsPerAllocatedToken
+    ) internal {
         State storage allocation = _get(self, allocationId);
         require(allocation.isOpen(), AllocationClosed(allocationId, allocation.closedAt));
-        allocation.accRewardsPending = 0;
+        allocation.accRewardsPerAllocatedToken = accRewardsPerAllocatedToken;
     }
 
     /**
-     * @notice Close an allocation
+     * @notice Update the accumulated rewards pending to be claimed for an allocation
      * @dev Requirements:
      * - The allocation must be open
      * @param self The allocation list mapping
      * @param allocationId The allocation id
      */
-    function close(mapping(address => State) storage self, address allocationId) external {
+    function clearPendingRewards(mapping(address => State) storage self, address allocationId) internal {
         State storage allocation = _get(self, allocationId);
         require(allocation.isOpen(), AllocationClosed(allocationId, allocation.closedAt));
-        allocation.closedAt = block.timestamp;
+        allocation.accRewardsPending = 0;
     }
 
     /**
-     * @notice Update the accumulated rewards per allocated token for an allocation
+     * @notice Close an allocation
      * @dev Requirements:
      * - The allocation must be open
      * @param self The allocation list mapping
      * @param allocationId The allocation id
-     * @param accRewardsPerAllocatedToken The new accumulated rewards per allocated token
      */
-    function snapshotRewards(
-        mapping(address => State) storage self,
-        address allocationId,
-        uint256 accRewardsPerAllocatedToken
-    ) internal {
+    function close(mapping(address => State) storage self, address allocationId) internal {
         State storage allocation = _get(self, allocationId);
         require(allocation.isOpen(), AllocationClosed(allocationId, allocation.closedAt));
-        allocation.accRewardsPerAllocatedToken = accRewardsPerAllocatedToken;
+        allocation.closedAt = block.timestamp;
     }
 
     /**