Skip to content

Commit 8d73fc3

Browse files
committed
fix: check deadline before recovering signature (C4 QA)
1 parent e789403 commit 8d73fc3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

contracts/l2/token/GraphTokenUpgradeable.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ contract GraphTokenUpgradeable is GraphUpgradeable, Governed, ERC20BurnableUpgra
8989
bytes32 _r,
9090
bytes32 _s
9191
) external {
92+
require(_deadline == 0 || block.timestamp <= _deadline, "GRT: expired permit");
9293
bytes32 digest = keccak256(
9394
abi.encodePacked(
9495
"\x19\x01",
@@ -101,7 +102,6 @@ contract GraphTokenUpgradeable is GraphUpgradeable, Governed, ERC20BurnableUpgra
101102

102103
address recoveredAddress = ECDSA.recover(digest, _v, _r, _s);
103104
require(_owner == recoveredAddress, "GRT: invalid permit");
104-
require(_deadline == 0 || block.timestamp <= _deadline, "GRT: expired permit");
105105

106106
nonces[_owner] = nonces[_owner] + 1;
107107
_approve(_owner, _spender, _value);

0 commit comments

Comments
 (0)