chore: add a confirmation step before deploying from CLI

Author: abarmat

cli/commands/deploy.ts

@@ -9,13 +9,18 @@ import {
 } from '../network'
 import { loadEnv, CLIArgs, CLIEnvironment } from '../env'
 import { logger } from '../logging'
+import { confirm } from '../helpers'
 
 export const deploy = async (cli: CLIEnvironment, cliArgs: CLIArgs): Promise<void> => {
   const contractName = cliArgs.contract
   const initArgs = cliArgs.init
   const deployType = cliArgs.type
   const buildAcceptProxyTx = cliArgs.buildTx
 
+  // Ensure action
+  const sure = await confirm(`Are you sure to deploy ${contractName}?`)
+  if (!sure) return
+
   // Deploy contract
   const contractArgs = initArgs ? initArgs.split(',') : []
   switch (deployType) {

cli/commands/proxy/admin.ts

@@ -1,9 +1,9 @@
-import inquirer from 'inquirer'
 import yargs, { Argv } from 'yargs'
 
 import { logger } from '../../logging'
 import { getContractAt, sendTransaction } from '../../network'
 import { loadEnv, CLIArgs, CLIEnvironment } from '../../env'
+import { confirm } from '../../helpers'
 
 export const setProxyAdmin = async (cli: CLIEnvironment, cliArgs: CLIArgs): Promise<void> => {
   const contractName = cliArgs.contract
@@ -12,13 +12,8 @@ export const setProxyAdmin = async (cli: CLIEnvironment, cliArgs: CLIArgs): Prom
   logger.info(`Set proxy admin for contract ${contractName} to ${adminAddress}`)
 
   // Warn about changing ownership
-  const res = await inquirer.prompt({
-    name: 'confirm',
-    type: 'confirm',
-    message: `Are you sure to set the admin to ${adminAddress}?`,
-  })
-  if (!res.confirm) {
-    logger.info('Cancelled')
+  const sure = await confirm(`Are you sure to set the admin to ${adminAddress}?`)
+  if (!sure) {
     return
   }
 

cli/helpers.ts

@@ -3,6 +3,7 @@ import * as dotenv from 'dotenv'
 
 import { utils, providers, Wallet } from 'ethers'
 import ipfsHttpClient from 'ipfs-http-client'
+import inquirer from 'inquirer'
 
 import * as bs58 from 'bs58'
 
@@ -89,3 +90,16 @@ export const pinMetadataToIPFS = async (
   logger.info(`Upload metadata successful: ${metaHash}\n`)
   return IPFS.ipfsHashToBytes32(metaHash)
 }
+
+export const confirm = async (message: string): Promise<boolean> => {
+  const res = await inquirer.prompt({
+    name: 'confirm',
+    type: 'confirm',
+    message,
+  })
+  if (!res.confirm) {
+    logger.info('Cancelled')
+    return false
+  }
+  return true
+}