feat: move interface ID generation to interfaces package

- Move InterfaceIdExtractor contract to interfaces package
- Move interface ID generation script to interfaces package
- Integrate interface ID generation into interfaces package build process
- Update contracts package to use interface IDs from interfaces package
- Remove local interface ID generation from contracts package
- Place generated interface IDs in src/types/interfaceIds.ts following package conventions

This centralizes interface ID generation in the interfaces package where it belongs,
making it available for all packages to use and eliminating duplication.

Author: RembrandtK

packages/contracts/contracts/tests/MockIssuanceAllocator.sol

@@ -139,7 +139,10 @@ contract MockIssuanceAllocator is ERC165, IIssuanceAllocator {
      * @inheritdoc IIssuanceAllocator
      * @dev Mock implementation that forces notification and returns current block
      */
-    function forceTargetNoChangeNotificationBlock(address target, uint256 blockNumber) external override returns (uint256) {
+    function forceTargetNoChangeNotificationBlock(
+        address target,
+        uint256 blockNumber
+    ) external override returns (uint256) {
         require(!_shouldRevert, "MockIssuanceAllocator: reverted");
         if (_allocatedTargets[target]) {
             IIssuanceTarget(target).beforeIssuanceAllocationChange();

packages/contracts/package.json

@@ -30,9 +30,8 @@
     "prepack": "pnpm build",
     "clean": "rm -rf artifacts/ cache/ types/ abis/ build/ dist/ coverage/",
     "build": "pnpm build:self",
-    "build:self": "pnpm compile && pnpm generate:interface-ids",
+    "build:self": "pnpm compile",
     "compile": "hardhat compile",
-    "generate:interface-ids": "cd test && python3 scripts/generateInterfaceIds.py",
     "test": "pnpm --filter @graphprotocol/contracts-tests test",
     "test:coverage": "pnpm --filter @graphprotocol/contracts-tests run test:coverage",
     "deploy": "pnpm predeploy && pnpm build",

packages/contracts/test/helpers/interfaceIds.ts

@@ -186,25 +186,12 @@ describe('Rewards', () => {
       })
 
       it('should support IRewardsManager interface', async function () {
-        // Use the auto-generated interface ID from Solidity compilation
-        const { IRewardsManager } = require('../../../helpers/interfaceIds')
+        // Use the auto-generated interface ID from the interfaces package
+        const { IRewardsManager } = require('@graphprotocol/interfaces')
         const supports = await rewardsManager.supportsInterface(IRewardsManager)
         expect(supports).to.be.true
       })
 
-      it('should have consistent interface IDs with Solidity calculations', async function () {
-        const InterfaceIdExtractorFactory = await hre.ethers.getContractFactory('InterfaceIdExtractor')
-        const extractor = await InterfaceIdExtractorFactory.deploy()
-        await extractor.deployed()
-
-        const { IRewardsManager, IIssuanceTarget, IERC165 } = require('../../../helpers/interfaceIds')
-
-        // Verify each interface ID matches what Solidity calculates
-        expect(await extractor.getIRewardsManagerId()).to.equal(IRewardsManager)
-        expect(await extractor.getIIssuanceTargetId()).to.equal(IIssuanceTarget)
-        expect(await extractor.getIERC165Id()).to.equal(IERC165)
-      })
-
       it('should support IERC165 interface', async function () {
         // Test the specific IERC165 interface - this should hit the third branch
         // interfaceId == type(IERC165).interfaceId

packages/contracts/test/tests/unit/rewards/rewards.test.ts

@@ -1,8 +1,8 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 pragma solidity 0.7.6;
 
-import { IRewardsManager } from "@graphprotocol/interfaces/contracts/contracts/rewards/IRewardsManager.sol";
-import { IIssuanceTarget } from "@graphprotocol/interfaces/contracts/issuance/allocate/IIssuanceTarget.sol";
+import { IRewardsManager } from "../contracts/rewards/IRewardsManager.sol";
+import { IIssuanceTarget } from "../issuance/allocate/IIssuanceTarget.sol";
 import { IERC165 } from "@openzeppelin/contracts/introspection/IERC165.sol";
 
 /**

packages/contracts/contracts/tests/InterfaceIdExtractor.sol renamed to packages/interfaces/contracts/utils/InterfaceIdExtractor.sol

@@ -41,6 +41,10 @@ find_files() {
 echo "📦 Compiling contracts with Hardhat..."
 pnpm hardhat compile
 
+# Step 1.5: Generate interface IDs
+echo "🔧 Generating interface IDs..."
+python3 scripts/generateInterfaceIds.py
+
 # Step 2: Generate types (only if needed)
 echo "🏗️  Checking type definitions..."
 

packages/interfaces/scripts/build.sh

@@ -26,14 +26,14 @@ def run_hardhat_task():
 async function main() {
   const InterfaceIdExtractor = await hre.ethers.getContractFactory('InterfaceIdExtractor')
   const extractor = await InterfaceIdExtractor.deploy()
-  await extractor.deployed()
-  
+  await extractor.waitForDeployment()
+
   const results = {
     IRewardsManager: await extractor.getIRewardsManagerId(),
     IIssuanceTarget: await extractor.getIIssuanceTargetId(),
     IERC165: await extractor.getIERC165Id(),
   }
-  
+
   console.log(JSON.stringify(results))
 }
 
@@ -44,7 +44,7 @@ def run_hardhat_task():
 """
 
     script_dir = Path(__file__).parent
-    project_dir = script_dir.parent.parent
+    project_dir = script_dir.parent
 
     # Write temporary script
     with tempfile.NamedTemporaryFile(mode='w', suffix='.js', delete=False) as temp_file:
@@ -62,7 +62,8 @@ def run_hardhat_task():
         )
 
         if result.returncode != 0:
-            raise RuntimeError(f"Hardhat script failed with code {result.returncode}: {result.stderr}")
+            raise RuntimeError(
+                f"Hardhat script failed with code {result.returncode}: {result.stderr}")
 
         # Extract JSON from output
         for line in result.stdout.split('\n'):
@@ -90,7 +91,8 @@ def run_hardhat_task():
 def extract_interface_ids():
     """Extract interface IDs using the InterfaceIdExtractor contract"""
     script_dir = Path(__file__).parent
-    extractor_path = script_dir.parent.parent / "artifacts" / "contracts" / "tests" / "InterfaceIdExtractor.sol" / "InterfaceIdExtractor.json"
+    extractor_path = script_dir.parent / "artifacts" / "contracts" / \
+        "utils" / "InterfaceIdExtractor.sol" / "InterfaceIdExtractor.json"
 
     if not extractor_path.exists():
         print("❌ InterfaceIdExtractor artifact not found")
@@ -137,14 +139,11 @@ def main():
 
     # Write to output file
     script_dir = Path(__file__).parent
-    output_file = script_dir.parent / "helpers" / "interfaceIds.ts"
-    
-    # Create helpers directory if it doesn't exist
-    output_file.parent.mkdir(exist_ok=True)
-    
+    output_file = script_dir.parent / "src" / "types" / "interfaceIds.ts"
+
     with open(output_file, 'w') as f:
         f.write(content)
-    
+
     log(f"✅ Generated {output_file}")
 
 

packages/contracts/test/scripts/generateInterfaceIds.py renamed to packages/interfaces/scripts/generateInterfaceIds.py

@@ -3,6 +3,7 @@ import { ContractRunner, Interface } from 'ethers'
 import { factories } from '../types'
 
 export * from './types/horizon'
+export * from './types/interfaceIds'
 export * from './types/subgraph-service'
 
 /**