fix: apply consistent mapping order HorizonStakingNotAuthorized (OZ_N-05)

Author: MoonBoi9001

packages/horizon/contracts/interfaces/internal/IHorizonStakingMain.sol

@@ -336,7 +336,7 @@ interface IHorizonStakingMain {
      * @param serviceProvider The service provider address
      * @param verifier The verifier address
      */
-    error HorizonStakingNotAuthorized(address caller, address serviceProvider, address verifier);
+    error HorizonStakingNotAuthorized(address serviceProvider, address caller, address verifier);
 
     /**
      * @notice Thrown when attempting to create a provision with an invalid maximum verifier cut.

packages/horizon/contracts/staking/HorizonStaking.sol

@@ -56,7 +56,7 @@ contract HorizonStaking is HorizonStakingBase, IHorizonStakingMain {
     modifier onlyAuthorized(address serviceProvider, address verifier) {
         require(
             _isAuthorized(msg.sender, serviceProvider, verifier),
-            HorizonStakingNotAuthorized(msg.sender, serviceProvider, verifier)
+            HorizonStakingNotAuthorized(serviceProvider, msg.sender, verifier)
         );
         _;
     }

packages/horizon/test/staking/provision/deprovision.t.sol

@@ -75,8 +75,8 @@ contract HorizonStakingDeprovisionTest is HorizonStakingTest {
         vm.startPrank(users.operator);
         bytes memory expectedError = abi.encodeWithSignature(
             "HorizonStakingNotAuthorized(address,address,address)",
-            users.operator,
             users.indexer,
+            users.operator,
             subgraphDataServiceAddress
         );
         vm.expectRevert(expectedError);

packages/horizon/test/staking/provision/locked.t.sol

@@ -66,8 +66,8 @@ contract HorizonStakingProvisionLockedTest is HorizonStakingTest {
         vm.startPrank(users.operator);
         bytes memory expectedError = abi.encodeWithSignature(
             "HorizonStakingNotAuthorized(address,address,address)",
-            users.operator,
             users.indexer,
+            users.operator,
             subgraphDataServiceAddress
         );
         vm.expectRevert(expectedError);

packages/horizon/test/staking/provision/parameters.t.sol

@@ -42,8 +42,8 @@ contract HorizonStakingProvisionParametersTest is HorizonStakingTest {
         vm.expectRevert(
             abi.encodeWithSignature(
                 "HorizonStakingNotAuthorized(address,address,address)",
-                msg.sender,
                 users.indexer,
+                msg.sender,
                 subgraphDataServiceAddress
             )
         );

packages/horizon/test/staking/provision/provision.t.sol

@@ -102,8 +102,8 @@ contract HorizonStakingProvisionTest is HorizonStakingTest {
         vm.startPrank(users.operator);
         bytes memory expectedError = abi.encodeWithSignature(
             "HorizonStakingNotAuthorized(address,address,address)",
-            users.operator,
             users.indexer,
+            users.operator,
             subgraphDataServiceAddress
         );
         vm.expectRevert(expectedError);

packages/horizon/test/staking/provision/reprovision.t.sol

@@ -80,8 +80,8 @@ contract HorizonStakingReprovisionTest is HorizonStakingTest {
         vm.startPrank(users.operator);
         bytes memory expectedError = abi.encodeWithSignature(
             "HorizonStakingNotAuthorized(address,address,address)",
-            users.operator,
             users.indexer,
+            users.operator,
             newDataService
         );
         vm.expectRevert(expectedError);

packages/horizon/test/staking/provision/thaw.t.sol

@@ -49,8 +49,8 @@ contract HorizonStakingThawTest is HorizonStakingTest {
         vm.startPrank(users.operator);
         bytes memory expectedError = abi.encodeWithSignature(
             "HorizonStakingNotAuthorized(address,address,address)",
-            users.operator,
             users.indexer,
+            users.operator,
             subgraphDataServiceAddress
         );
         vm.expectRevert(expectedError);