f: remove this. from SubgraphService

matiasedgeandnode · matiasedgeandnode · commit bd3495eb1206 · 2025-06-04T13:23:49.000-03:00
diff --git a/packages/subgraph-service/contracts/SubgraphService.sol b/packages/subgraph-service/contracts/SubgraphService.sol
@@ -56,7 +56,7 @@ contract SubgraphService is
      * @param indexer The address of the indexer
      */
     modifier onlyRegisteredIndexer(address indexer) {
-        this.requireRegisteredIndexer(indexer);
+        _requireRegisteredIndexer(indexer);
         _;
     }
 
@@ -453,7 +453,7 @@ contract SubgraphService is
     }
 
     function requireRegisteredIndexer(address indexer) external view {
-        require(indexers[indexer].registeredAt != 0, SubgraphServiceIndexerNotRegistered(indexer));
+        _requireRegisteredIndexer(indexer);
     }
 
     /// @inheritdoc ISubgraphService
@@ -515,6 +515,10 @@ contract SubgraphService is
         return address(_graphStaking());
     }
 
+    function _requireRegisteredIndexer(address indexer) internal view {
+        require(indexers[indexer].registeredAt != 0, SubgraphServiceIndexerNotRegistered(indexer));
+    }
+
     function _cancelAllocationIndexingAgreement(address _allocationId) internal {
         IndexingAgreement._getManager().cancelForAllocation(_allocationId);
     }

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ contract SubgraphService is`
`56`	`56`	`* @param indexer The address of the indexer`
`57`	`57`	`*/`
`58`	`58`	`modifier onlyRegisteredIndexer(address indexer) {`
`59`		`- this.requireRegisteredIndexer(indexer);`
	`59`	`+ _requireRegisteredIndexer(indexer);`
`60`	`60`	`_;`
`61`	`61`	`}`
`62`	`62`
`@@ -453,7 +453,7 @@ contract SubgraphService is`
`453`	`453`	`}`
`454`	`454`
`455`	`455`	`function requireRegisteredIndexer(address indexer) external view {`
`456`		`- require(indexers[indexer].registeredAt != 0, SubgraphServiceIndexerNotRegistered(indexer));`
	`456`	`+ _requireRegisteredIndexer(indexer);`
`457`	`457`	`}`
`458`	`458`
`459`	`459`	`/// @inheritdoc ISubgraphService`
`@@ -515,6 +515,10 @@ contract SubgraphService is`
`515`	`515`	`return address(_graphStaking());`
`516`	`516`	`}`
`517`	`517`
	`518`	`+ function _requireRegisteredIndexer(address indexer) internal view {`
	`519`	`+ require(indexers[indexer].registeredAt != 0, SubgraphServiceIndexerNotRegistered(indexer));`
	`520`	`+ }`
	`521`	`+`
`518`	`522`	`function _cancelAllocationIndexingAgreement(address _allocationId) internal {`
`519`	`523`	`IndexingAgreement._getManager().cancelForAllocation(_allocationId);`
`520`	`524`	`}`