chore: use top level solhint config for horizon and add graph rules

Signed-off-by: Tomás Migone <[email protected]>

Author: tmigone

.solhint.json

@@ -1,12 +1,21 @@
 {
   "extends": "solhint:recommended",
+  "plugins": ["graph"],
   "rules": {
     "func-visibility": ["warn", { "ignoreConstructors": true }],
     "compiler-version": ["off"],
     "constructor-syntax": "warn",
     "quotes": ["error", "double"],
     "reason-string": ["off"],
     "not-rely-on-time": "off",
-    "no-empty-blocks": "off"
+    "no-empty-blocks": "off",
+    "named-parameters-mapping": "warn",
+    "private-vars-leading-underscore": "off",
+    "graph/leading-underscore": "warn",
+    "func-name-mixedcase": "off",
+    "graph/func-name-mixedcase": "warn",
+    "var-name-mixedcase": "off",
+    "graph/var-name-mixedcase": "warn",
+    "gas-custom-errors": "off"
   }
 }

package.json

@@ -49,6 +49,7 @@
     "prettier-plugin-solidity": "^1.0.0",
     "pretty-quick": "^4.1.1",
     "solhint": "^5.1.0",
+    "solhint-plugin-graph": "workspace:*",
     "typescript": "^5.8.3",
     "typescript-eslint": "^8.33.1",
     "yaml-lint": "^1.7.0"

packages/horizon/.solhintignore

@@ -1 +1 @@
-contracts/mocks/*
+lib/*

packages/horizon/contracts/mocks/CurationMock.sol

@@ -2,7 +2,6 @@
 
 pragma solidity 0.8.27;
 
-
 contract CurationMock {
     mapping(bytes32 => uint256) public curation;
 

packages/horizon/package.json

@@ -17,9 +17,7 @@
   "scripts": {
     "lint": "pnpm lint:ts && pnpm lint:sol",
     "lint:ts": "eslint --fix --cache '**/*.{js,ts,cjs,mjs,jsx,tsx}'; prettier -w --cache --log-level warn '**/*.{js,ts,cjs,mjs,jsx,tsx}'",
-    "lint:sol": "pnpm lint:sol:prettier && pnpm lint:sol:solhint",
-    "lint:sol:prettier": "prettier --write \"contracts/**/*.sol\" \"test/**/*.sol\"",
-    "lint:sol:solhint": "solhint --noPrompt --fix \"contracts/**/*.sol\" --config node_modules/solhint-graph-config/index.js",
+    "lint:sol": "solhint --config ../../.solhint.json --fix --noPrompt --noPoster 'contracts/**/*.sol'; prettier -w --cache --log-level warn '**/*.sol'",
     "lint:sol:natspec": "natspec-smells --config natspec-smells.config.js",
     "clean": "rm -rf build dist cache cache_forge typechain-types",
     "build": "hardhat compile",
@@ -59,8 +57,7 @@
     "lint-staged": "^15.2.2",
     "prettier": "^3.2.5",
     "prettier-plugin-solidity": "^1.3.1",
-    "solhint": "^4.5.2",
-    "solhint-plugin-graph": "workspace:^0.0.1",
+    "solhint": "^5.1.0",
     "solidity-coverage": "^0.8.0",
     "ts-node": ">=8.0.0",
     "typechain": "^8.3.0",

packages/horizon/test/unit/data-service/implementations/DataServiceImpPausableUpgradeable.sol

@@ -2,7 +2,9 @@
 pragma solidity 0.8.27;
 
 import { DataService } from "../../../../contracts/data-service/DataService.sol";
-import { DataServicePausableUpgradeable } from "../../../../contracts/data-service/extensions/DataServicePausableUpgradeable.sol";
+import {
+    DataServicePausableUpgradeable
+} from "../../../../contracts/data-service/extensions/DataServicePausableUpgradeable.sol";
 import { IGraphPayments } from "./../../../../contracts/interfaces/IGraphPayments.sol";
 
 contract DataServiceImpPausableUpgradeable is DataServicePausableUpgradeable {