fix(horizon): add explicit check of provision existance before accepting parameters

Signed-off-by: Tomás Migone <[email protected]>

Author: tmigone

packages/horizon/contracts/staking/HorizonStaking.sol

@@ -229,6 +229,8 @@ contract HorizonStaking is HorizonStakingBase, IHorizonStakingMain {
             newThawingPeriod <= _maxThawingPeriod,
             HorizonStakingInvalidThawingPeriod(newThawingPeriod, _maxThawingPeriod)
         );
+
+        // Provision must exist
         Provision storage prov = _provisions[serviceProvider][verifier];
         require(prov.createdAt != 0, HorizonStakingInvalidProvision(serviceProvider, verifier));
 
@@ -244,7 +246,11 @@ contract HorizonStaking is HorizonStakingBase, IHorizonStakingMain {
      */
     function acceptProvisionParameters(address serviceProvider) external override notPaused {
         address verifier = msg.sender;
+
+        // Provision must exist
         Provision storage prov = _provisions[serviceProvider][verifier];
+        require(prov.createdAt != 0, HorizonStakingInvalidProvision(serviceProvider, verifier));
+
         if ((prov.maxVerifierCutPending != prov.maxVerifierCut) || (prov.thawingPeriodPending != prov.thawingPeriod)) {
             prov.maxVerifierCut = prov.maxVerifierCutPending;
             prov.thawingPeriod = prov.thawingPeriodPending;

packages/horizon/test/staking/provision/parameters.t.sol

@@ -7,7 +7,6 @@ import { HorizonStakingTest } from "../HorizonStaking.t.sol";
 import { IHorizonStakingMain } from "../../../contracts/interfaces/internal/IHorizonStakingMain.sol";
 
 contract HorizonStakingProvisionParametersTest is HorizonStakingTest {
-
     /*
      * MODIFIERS
      */
@@ -83,6 +82,20 @@ contract HorizonStakingProvisionParametersTest is HorizonStakingTest {
         vm.stopPrank();
     }
 
+
+    function test_ProvisionParametersAccept_SameParameters(
+        uint256 amount,
+        uint32 maxVerifierCut,
+        uint64 thawingPeriod
+    ) public useIndexer useProvision(amount, maxVerifierCut, thawingPeriod) {
+        _setProvisionParameters(users.indexer, subgraphDataServiceAddress, maxVerifierCut, thawingPeriod);
+
+        vm.startPrank(subgraphDataServiceAddress);
+        _acceptProvisionParameters(users.indexer);
+        _acceptProvisionParameters(users.indexer);
+        vm.stopPrank();
+    }
+
     function test_ProvisionParameters_RevertIf_InvalidMaxVerifierCut(
         uint256 amount,
         uint32 maxVerifierCut,
@@ -91,10 +104,7 @@ contract HorizonStakingProvisionParametersTest is HorizonStakingTest {
         maxVerifierCut = uint32(bound(maxVerifierCut, MAX_PPM + 1, type(uint32).max));
         vm.assume(thawingPeriod <= MAX_THAWING_PERIOD);
         vm.expectRevert(
-            abi.encodeWithSelector(
-                IHorizonStakingMain.HorizonStakingInvalidMaxVerifierCut.selector,
-                maxVerifierCut
-            )
+            abi.encodeWithSelector(IHorizonStakingMain.HorizonStakingInvalidMaxVerifierCut.selector, maxVerifierCut)
         );
         staking.setProvisionParameters(users.indexer, subgraphDataServiceAddress, maxVerifierCut, thawingPeriod);
     }
@@ -115,4 +125,16 @@ contract HorizonStakingProvisionParametersTest is HorizonStakingTest {
         );
         staking.setProvisionParameters(users.indexer, subgraphDataServiceAddress, maxVerifierCut, thawingPeriod);
     }
+
+    function test_ProvisionParametersAccept_RevertWhen_ProvisionNotExists() public useIndexer {
+        resetPrank(subgraphDataServiceAddress);
+        vm.expectRevert(
+            abi.encodeWithSignature(
+                "HorizonStakingInvalidProvision(address,address)",
+                users.indexer,
+                subgraphDataServiceAddress
+            )
+        );
+        staking.acceptProvisionParameters(users.indexer);
+    }
 }