Modernise and cleanup lint configuration and build process (#1177)

Migrated eslint-graph-config and solhint-graph-config to be configuration files in repo root that are inherited from for packages. It is presumed we do not need to maintain these config packages for external dependencies, and they have been deleted.
Upgraded linting engines (ESLint, Solhint, Prettier) and added linting of Markdown, JSON, and YAML.
Upgraded to Node version 20 (from 18). Might not work anymore when using Node version 18.
Consistently made Prettier the last to process during linting, upgrading Prettier config to match ESLint config and avoid conflicts.
Changed import ordering to be automated (by running yarn lint) using eslint-plugin-simple-import-sort. Also sorts exports.
Dropped no-secrets ESLint plugin due to version conflicts and low signal to noise ratio.
Upgraded Yarn and resolved dependency version clashes.
Upgraded and simplified Husky pre-commit behaviour.
Currently using repo root .gitignore as single source for lint files to ignore. This is imperfect, and might need to be subsequently adjusted and revisited.
Attempted to preserve Lint/Prettier config parameters, however I think import and export sorting have changed, and in some cases dangling commas will be added where they were previously removed (an improvement IMO).
Upgraded linting engines mean more issues are detected, and likely some changes in behaviour.
Added incremental and cached linting and building in various places.
Bumping versions of contracts and token-distribution as the TS interfaces are not backwards compatible, and minor of other packages as should be considered a different version now.
GitHub workflow to run lints.

Author: RembrandtK

.devcontainer/Dockerfile

@@ -6,12 +6,10 @@ ENV DEBIAN_FRONTEND=noninteractive
 # Switch to root for installing packages
 USER root
 
-RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash -
-
 # Install additional dependencies
 RUN apt update && apt install -y \
     build-essential \
-    nodejs \
+    curl \
     jq \
     python3 \
     python3-pip \
@@ -20,8 +18,12 @@ RUN apt update && apt install -y \
     && apt clean \
     && rm -rf /var/lib/apt/lists/*
 
-# Install Node.js
-RUN npm install -g n && n 20.12.0
+# Install Node.js 20.x using NodeSource
+RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - && \
+    apt update && \
+    apt install -y nodejs && \
+    apt clean && \
+    rm -rf /var/lib/apt/lists/*
 
 # Install Solidity compiler using pipx (isolated environment)
 RUN pipx install solc-select && \
@@ -59,9 +61,10 @@ RUN curl -L https://foundry.paradigm.xyz | bash && \
     chmod 755 /usr/local/bin/forge && \
     chmod 755 /usr/local/bin/chisel
 
-# Set up yarn
+# Set up yarn and pnpm
 RUN corepack enable && \
-    corepack prepare [email protected] --activate
+    corepack prepare [email protected] --activate && \
+    corepack prepare [email protected] --activate
 
 # Ensure all users have access to the tools
 RUN chmod 755 /usr/local/bin/* && \

.devcontainer/docker-compose.yml

@@ -36,8 +36,14 @@ services:
       - vscode-data:/home/vscode/.local/share
       - vscode-bin:/home/vscode/.local/bin
 
+      # Shared pnpm cache (safe due to content-addressable storage)
+      - pnpm-store:/home/vscode/.local/share/pnpm
+      - pnpm-cache:/home/vscode/.cache/pnpm
+
 volumes:
   vscode-cache:
   vscode-config:
   vscode-data:
   vscode-bin:
+  pnpm-store:
+  pnpm-cache:

.devcontainer/setup-git-signing.sh

@@ -1,4 +1,4 @@
-#!/bin/env bash
+#!/usr/bin/env bash
 # Automatically configure Git to use SSH signing with forwarded SSH keys
 set -euo pipefail
 

.github/actions/setup/action.yml

@@ -4,13 +4,18 @@ runs:
   using: composite
 
   steps:
+    - name: Install system dependencies
+      shell: bash
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y libudev-dev libusb-1.0-0-dev
     - name: Enable corepack for modern yarn
       shell: bash
       run: corepack enable
     - name: Install Node.js
       uses: actions/setup-node@v4
       with:
-        node-version: 18
+        node-version: 20
         cache: 'yarn'
     - name: Install dependencies
       shell: bash

.github/workflows/ci-contracts.yml

@@ -5,11 +5,11 @@ env:
 
 on:
   push:
-    branches: "*"
+    branches: '*'
     paths:
       - packages/contracts/**
   pull_request:
-    branches: "*"
+    branches: '*'
     paths:
       - packages/contracts/**
   workflow_dispatch:
@@ -22,10 +22,13 @@ jobs:
         uses: actions/checkout@v4
       - name: Set up environment
         uses: ./.github/actions/setup
-      - name: Build
+      - name: Build dependencies
         run: |
           pushd packages/contracts
-          yarn build || yarn build
+          yarn build
+          popd
+          pushd packages/sdk
+          yarn build
       - name: Run tests
         run: |
           pushd packages/contracts

.github/workflows/ci-data-edge.yml

@@ -5,11 +5,11 @@ env:
 
 on:
   push:
-    branches: "*"
+    branches: '*'
     paths:
       - packages/data-edge/**
   pull_request:
-    branches: "*"
+    branches: '*'
     paths:
       - packages/data-edge/**
   workflow_dispatch:
@@ -27,4 +27,6 @@ jobs:
           pushd packages/data-edge
           yarn build
       - name: Run tests
-        run: yarn test
+        run: |
+          pushd packages/data-edge
+          yarn test

.github/workflows/ci-token-dist.yml

@@ -6,11 +6,11 @@ env:
 
 on:
   push:
-    branches: "*"
+    branches: '*'
     paths:
       - packages/token-distribution/**
   pull_request:
-    branches: "*"
+    branches: '*'
     paths:
       - packages/token-distribution/**
   workflow_dispatch:
@@ -23,9 +23,15 @@ jobs:
         uses: actions/checkout@v4
       - name: Set up environment
         uses: ./.github/actions/setup
+      - name: Build contracts (dependency)
+        run: |
+          pushd packages/contracts
+          yarn build
       - name: Build
         run: |
           pushd packages/token-distribution
           yarn build
       - name: Run tests
-        run: yarn test
+        run: |
+          pushd packages/token-distribution
+          yarn test