misc: review function visibility

Author: abarmat

contracts/curation/Curation.sol

@@ -348,7 +348,7 @@ contract Curation is CurationV1Storage, GraphUpgradeable, ICuration {
      * @return Amount of token reserves in the curation pool
      */
     function getCurationPoolTokens(bytes32 _subgraphDeploymentID)
-        public
+        external
         override
         view
         returns (uint256)
@@ -381,7 +381,7 @@ contract Curation is CurationV1Storage, GraphUpgradeable, ICuration {
      * @return Amount of signal that can be bought with tokens
      */
     function _tokensToSignal(bytes32 _subgraphDeploymentID, uint256 _tokensIn)
-        internal
+        private
         view
         returns (uint256)
     {
@@ -450,7 +450,7 @@ contract Curation is CurationV1Storage, GraphUpgradeable, ICuration {
      * @dev Triggers an update of rewards due to a change in signal.
      * @param _subgraphDeploymentID Subgraph deployment updated
      */
-    function _updateRewards(bytes32 _subgraphDeploymentID) internal {
+    function _updateRewards(bytes32 _subgraphDeploymentID) private {
         IRewardsManager rewardsManager = rewardsManager();
         if (address(rewardsManager) != address(0)) {
             rewardsManager.onSubgraphSignalUpdate(_subgraphDeploymentID);

contracts/discovery/GNS.sol

@@ -181,7 +181,7 @@ contract GNS is GNSV1Storage, GraphUpgradeable, IGNS {
      * the name curators tokens while upgrading or deprecating and is configurable in parts per hundred.
      * @param _ownerTaxPercentage Owner tax percentage
      */
-    function _setOwnerTaxPercentage(uint32 _ownerTaxPercentage) internal {
+    function _setOwnerTaxPercentage(uint32 _ownerTaxPercentage) private {
         require(_ownerTaxPercentage <= 100, "Owner tax must be 100 or less");
         ownerTaxPercentage = _ownerTaxPercentage;
         emit ParameterUpdated("ownerTaxPercentage");

contracts/discovery/ServiceRegistry.sol

@@ -70,7 +70,7 @@ contract ServiceRegistry is Managed, IServiceRegistry {
         address _indexer,
         string calldata _url,
         string calldata _geohash
-    ) internal {
+    ) private {
         require(_isAuth(_indexer), "!auth");
         require(bytes(_url).length > 0, "Service must specify a URL");
 
@@ -98,7 +98,7 @@ contract ServiceRegistry is Managed, IServiceRegistry {
      * @dev Unregister an indexer service
      * @param _indexer Address of the indexer
      */
-    function _unregister(address _indexer) internal {
+    function _unregister(address _indexer) private {
         require(_isAuth(_indexer), "!auth");
         require(isRegistered(_indexer), "Service already unregistered");
 

contracts/disputes/DisputeManager.sol

@@ -475,7 +475,7 @@ contract DisputeManager is Managed, IDisputeManager {
         uint256 _deposit,
         Attestation memory _attestation,
         bytes memory _attestationData
-    ) internal returns (bytes32) {
+    ) private returns (bytes32) {
         // Get the indexer that signed the attestation
         address indexer = getAttestationIndexer(_attestation);
 
@@ -547,7 +547,7 @@ contract DisputeManager is Managed, IDisputeManager {
         address _fisherman,
         uint256 _deposit,
         address _allocationID
-    ) internal returns (bytes32) {
+    ) private returns (bytes32) {
         // Create a disputeID
         bytes32 disputeID = keccak256(abi.encodePacked(_allocationID));
 
@@ -664,7 +664,7 @@ contract DisputeManager is Managed, IDisputeManager {
      * @param _dispute Dispute
      * @return True conflicting attestation dispute
      */
-    function _isDisputeInConflict(Dispute memory _dispute) internal pure returns (bool) {
+    function _isDisputeInConflict(Dispute memory _dispute) private pure returns (bool) {
         return _dispute.relatedDisputeID != 0;
     }
 
@@ -673,7 +673,7 @@ contract DisputeManager is Managed, IDisputeManager {
      * @param _dispute Dispute
      * @return True if resolved
      */
-    function _resolveDisputeInConflict(Dispute memory _dispute) internal returns (bool) {
+    function _resolveDisputeInConflict(Dispute memory _dispute) private returns (bool) {
         if (_isDisputeInConflict(_dispute)) {
             bytes32 relatedDisputeID = _dispute.relatedDisputeID;
             delete disputes[relatedDisputeID];
@@ -686,7 +686,7 @@ contract DisputeManager is Managed, IDisputeManager {
      * @dev Pull deposit from submitter account.
      * @param _deposit Amount of tokens to deposit
      */
-    function _pullSubmitterDeposit(uint256 _deposit) internal {
+    function _pullSubmitterDeposit(uint256 _deposit) private {
         // Ensure that fisherman has staked at least the minimum amount
         require(_deposit >= minimumDeposit, "Dispute deposit is under minimum required");
 
@@ -704,7 +704,7 @@ contract DisputeManager is Managed, IDisputeManager {
      * @param _challenger Address of the challenger
      * @return Dispute reward tokens
      */
-    function _slashIndexer(address _indexer, address _challenger) internal returns (uint256) {
+    function _slashIndexer(address _indexer, address _challenger) private returns (uint256) {
         // Have staking contract slash the indexer and reward the fisherman
         // Give the fisherman a reward equal to the fishermanRewardPercentage of slashed amount
         uint256 tokensToSlash = getTokensToSlash(_indexer);
@@ -722,7 +722,7 @@ contract DisputeManager is Managed, IDisputeManager {
      * @return Signer address
      */
     function _recoverAttestationSigner(Attestation memory _attestation)
-        internal
+        private
         view
         returns (address)
     {
@@ -747,7 +747,7 @@ contract DisputeManager is Managed, IDisputeManager {
      * @dev Get the running network chain ID
      * @return The chain ID
      */
-    function _getChainID() internal pure returns (uint256) {
+    function _getChainID() private pure returns (uint256) {
         uint256 id;
         assembly {
             id := chainid()
@@ -759,7 +759,7 @@ contract DisputeManager is Managed, IDisputeManager {
      * @dev Parse the bytes attestation into a struct from `_data`.
      * @return Attestation struct
      */
-    function _parseAttestation(bytes memory _data) internal pure returns (Attestation memory) {
+    function _parseAttestation(bytes memory _data) private pure returns (Attestation memory) {
         // Check attestation data length
         require(_data.length == ATTESTATION_SIZE_BYTES, "Attestation must be 161 bytes long");
 
@@ -782,7 +782,7 @@ contract DisputeManager is Managed, IDisputeManager {
      * @dev Parse a uint8 from `_bytes` starting at offset `_start`.
      * @return uint8 value
      */
-    function _toUint8(bytes memory _bytes, uint256 _start) internal pure returns (uint8) {
+    function _toUint8(bytes memory _bytes, uint256 _start) private pure returns (uint8) {
         require(_bytes.length >= (_start + UINT8_BYTE_LENGTH), "Bytes: out of bounds");
         uint8 tempUint;
 
@@ -797,7 +797,7 @@ contract DisputeManager is Managed, IDisputeManager {
      * @dev Parse a bytes32 from `_bytes` starting at offset `_start`.
      * @return bytes32 value
      */
-    function _toBytes32(bytes memory _bytes, uint256 _start) internal pure returns (bytes32) {
+    function _toBytes32(bytes memory _bytes, uint256 _start) private pure returns (bytes32) {
         require(_bytes.length >= (_start + BYTES32_BYTE_LENGTH), "Bytes: out of bounds");
         bytes32 tempBytes32;
 

contracts/epochs/EpochManager.sol

@@ -87,7 +87,7 @@ contract EpochManager is EpochManagerV1Storage, GraphUpgradeable, IEpochManager
      * @dev Return blockhash for a block.
      * @return BlockHash for `_block` number
      */
-    function blockHash(uint256 _block) public override view returns (bytes32) {
+    function blockHash(uint256 _block) external override view returns (bytes32) {
         uint256 currentBlock = blockNum();
 
         require(_block < currentBlock, "Can only retrieve past block hashes");
@@ -119,7 +119,7 @@ contract EpochManager is EpochManagerV1Storage, GraphUpgradeable, IEpochManager
      * @dev Return the number of blocks that passed since current epoch started.
      * @return Blocks that passed since start of epoch
      */
-    function currentEpochBlockSinceStart() public override view returns (uint256) {
+    function currentEpochBlockSinceStart() external override view returns (uint256) {
         return blockNum() - currentEpochBlock();
     }
 
@@ -128,7 +128,7 @@ contract EpochManager is EpochManagerV1Storage, GraphUpgradeable, IEpochManager
      * @param _epoch Epoch to use as since epoch value
      * @return Number of epochs and current epoch
      */
-    function epochsSince(uint256 _epoch) public override view returns (uint256) {
+    function epochsSince(uint256 _epoch) external override view returns (uint256) {
         uint256 epoch = currentEpoch();
         return _epoch < epoch ? epoch.sub(_epoch) : 0;
     }

contracts/rewards/RewardsManager.sol

@@ -66,7 +66,7 @@ contract RewardsManager is RewardsManagerV1Storage, GraphUpgradeable, IRewardsMa
      * To accommodate a high precision the issuance rate is expressed in wei.
      * @param _issuanceRate Issuance rate expressed in wei
      */
-    function setIssuanceRate(uint256 _issuanceRate) public override onlyGovernor {
+    function setIssuanceRate(uint256 _issuanceRate) external override onlyGovernor {
         _setIssuanceRate(_issuanceRate);
     }
 
@@ -133,7 +133,7 @@ contract RewardsManager is RewardsManagerV1Storage, GraphUpgradeable, IRewardsMa
      * @param _subgraphDeploymentID Subgraph deployment ID
      * @param _deny Whether to set the subgraph as denied for claiming rewards or not
      */
-    function _setDenied(bytes32 _subgraphDeploymentID, bool _deny) internal {
+    function _setDenied(bytes32 _subgraphDeploymentID, bool _deny) private {
         uint256 sinceBlock = _deny ? block.number : 0;
         denylist[_subgraphDeploymentID] = sinceBlock;
         emit RewardsDenylistUpdated(_subgraphDeploymentID, sinceBlock);
@@ -272,7 +272,7 @@ contract RewardsManager is RewardsManagerV1Storage, GraphUpgradeable, IRewardsMa
      * @return Accumulated rewards for subgraph
      */
     function onSubgraphSignalUpdate(bytes32 _subgraphDeploymentID)
-        public
+        external
         override
         returns (uint256)
     {
@@ -314,7 +314,7 @@ contract RewardsManager is RewardsManagerV1Storage, GraphUpgradeable, IRewardsMa
      * @param _allocationID Allocation
      * @return Rewards amount for an allocation
      */
-    function getRewards(address _allocationID) public override view returns (uint256) {
+    function getRewards(address _allocationID) external override view returns (uint256) {
         IStaking.Allocation memory alloc = staking().getAllocation(_allocationID);
 
         (uint256 accRewardsPerAllocatedToken, ) = getAccRewardsPerAllocatedToken(
@@ -339,7 +339,7 @@ contract RewardsManager is RewardsManagerV1Storage, GraphUpgradeable, IRewardsMa
         uint256 _tokens,
         uint256 _startAccRewardsPerAllocatedToken,
         uint256 _endAccRewardsPerAllocatedToken
-    ) internal pure returns (uint256) {
+    ) private pure returns (uint256) {
         uint256 newAccrued = _endAccRewardsPerAllocatedToken.sub(_startAccRewardsPerAllocatedToken);
         return newAccrued.mul(_tokens).div(TOKEN_DECIMALS);
     }
@@ -394,7 +394,7 @@ contract RewardsManager is RewardsManagerV1Storage, GraphUpgradeable, IRewardsMa
         uint256 x,
         uint256 n,
         uint256 base
-    ) internal pure returns (uint256 z) {
+    ) private pure returns (uint256 z) {
         assembly {
             switch x
                 case 0 {