staking: unreachable condition in tokensWithdrawable function

abarmat · abarmat · commit d7be96cbd948 · 2020-10-03T22:31:36.000-03:00
diff --git a/contracts/staking/libs/Stakes.sol b/contracts/staking/libs/Stakes.sol
@@ -176,12 +176,6 @@ library Stakes {
         if (stake.tokensLockedUntil == 0 || block.number < stake.tokensLockedUntil) {
             return 0;
         }
-        // Cannot withdraw more than currently staked
-        // This condition can happen if while tokens are locked for withdrawal a slash condition happens
-        // In that case the total staked tokens could be below the amount to be withdrawn
-        if (stake.tokensLocked > stake.tokensStaked) {
-            return stake.tokensStaked;
-        }
         return stake.tokensLocked;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -176,12 +176,6 @@ library Stakes {`
`176`	`176`	`if (stake.tokensLockedUntil == 0 \|\| block.number < stake.tokensLockedUntil) {`
`177`	`177`	`return 0;`
`178`	`178`	`}`
`179`		`- // Cannot withdraw more than currently staked`
`180`		`- // This condition can happen if while tokens are locked for withdrawal a slash condition happens`
`181`		`- // In that case the total staked tokens could be below the amount to be withdrawn`
`182`		`- if (stake.tokensLocked > stake.tokensStaked) {`
`183`		`- return stake.tokensStaked;`
`184`		`- }`
`185`	`179`	`return stake.tokensLocked;`
`186`	`180`	`}`
`187`	`181`	`}`