feat: not only IA can call beforeIssuanceAllocationChange()

Author: RembrandtK

packages/contracts/contracts/rewards/RewardsManager.sol

@@ -220,16 +220,12 @@ contract RewardsManager is RewardsManagerV7Storage, GraphUpgradeable, ERC165, IR
      * @dev Ensures that all reward calculations are up-to-date with the current block
      * before any allocation changes take effect.
      *
+     * This function can be called by anyone to update the rewards calculation state.
      * The IssuanceAllocator calls this function before changing a target's allocation to ensure
      * all issuance is properly accounted for with the current issuance rate before applying an
      * issuance allocation change.
-     *
-     * Only the IssuanceAllocator can call this function to ensure proper access control
-     * for any future changes that might require this level of restriction.
      */
     function beforeIssuanceAllocationChange() external override {
-        require(msg.sender == address(issuanceAllocator), "Caller must be IssuanceAllocator");
-
         // Update rewards calculation with the current issuance rate
         updateAccRewardsPerSignal();
     }

packages/contracts/test/tests/unit/rewards/rewards.test.ts

@@ -326,11 +326,10 @@ describe('Rewards', () => {
         await mockIssuanceAllocator.deployed()
         await rewardsManager.connect(governor).setIssuanceAllocator(mockIssuanceAllocator.address)
 
-        // Only the allocator should be able to call this function
-        const tx1 = rewardsManager.connect(governor).beforeIssuanceAllocationChange()
-        await expect(tx1).revertedWith('Caller must be IssuanceAllocator')
+        // Anyone should be able to call this function
+        await rewardsManager.connect(governor).beforeIssuanceAllocationChange()
 
-        // Should succeed when called by the allocator
+        // Should also succeed when called by the allocator
         await mockIssuanceAllocator.callBeforeIssuanceAllocationChange(rewardsManager.address)
       })