f: rename _hashRCA*712

Author: matiasedgeandnode

packages/horizon/contracts/interfaces/IRecurringCollector.sol

@@ -317,14 +317,14 @@ interface IRecurringCollector is IAuthorizable, IPaymentsCollector {
      * @param rca The RCA for which to compute the hash.
      * @return The hash of the RCA.
      */
-    function hashRCA712(RecurringCollectionAgreement calldata rca) external view returns (bytes32);
+    function hashRCA(RecurringCollectionAgreement calldata rca) external view returns (bytes32);
 
     /**
      * @dev Computes the hash of a RecurringCollectionAgreementUpdate (RCAU).
      * @param rcau The RCAU for which to compute the hash.
      * @return The hash of the RCAU.
      */
-    function hashRCAU712(RecurringCollectionAgreementUpdate calldata rcau) external view returns (bytes32);
+    function hashRCAU(RecurringCollectionAgreementUpdate calldata rcau) external view returns (bytes32);
 
     /**
      * @dev Recovers the signer address of a signed RecurringCollectionAgreement (RCA).

packages/horizon/contracts/payments/collectors/RecurringCollector.sol

@@ -213,17 +213,17 @@ contract RecurringCollector is EIP712, GraphDirectory, Authorizable, IRecurringC
     }
 
     /**
-     * @notice See {IRecurringCollector.hashRCA712}
+     * @notice See {IRecurringCollector.hashRCA}
      */
-    function hashRCA712(RecurringCollectionAgreement calldata rca) external view returns (bytes32) {
-        return _hashRCA712(rca);
+    function hashRCA(RecurringCollectionAgreement calldata rca) external view returns (bytes32) {
+        return _hashRCA(rca);
     }
 
     /**
-     * @notice See {IRecurringCollector.hashRCAU712}
+     * @notice See {IRecurringCollector.hashRCAU}
      */
-    function hashRCAU712(RecurringCollectionAgreementUpdate calldata rcau) external view returns (bytes32) {
-        return _hashRCAU712(rcau);
+    function hashRCAU(RecurringCollectionAgreementUpdate calldata rcau) external view returns (bytes32) {
+        return _hashRCAU(rcau);
     }
 
     /**
@@ -371,22 +371,22 @@ contract RecurringCollector is EIP712, GraphDirectory, Authorizable, IRecurringC
      * @notice See {IRecurringCollector.recoverRCASigner}
      */
     function _recoverRCASigner(SignedRCA memory _signedRCA) private view returns (address) {
-        bytes32 messageHash = _hashRCA712(_signedRCA.rca);
+        bytes32 messageHash = _hashRCA(_signedRCA.rca);
         return ECDSA.recover(messageHash, _signedRCA.signature);
     }
 
     /**
      * @notice See {IRecurringCollector.recoverRCAUSigner}
      */
     function _recoverRCAUSigner(SignedRCAU memory _signedRCAU) private view returns (address) {
-        bytes32 messageHash = _hashRCAU712(_signedRCAU.rcau);
+        bytes32 messageHash = _hashRCAU(_signedRCAU.rcau);
         return ECDSA.recover(messageHash, _signedRCAU.signature);
     }
 
     /**
-     * @notice See {IRecurringCollector.hashRCA712}
+     * @notice See {IRecurringCollector.hashRCA}
      */
-    function _hashRCA712(RecurringCollectionAgreement memory _rca) private view returns (bytes32) {
+    function _hashRCA(RecurringCollectionAgreement memory _rca) private view returns (bytes32) {
         return
             _hashTypedDataV4(
                 keccak256(
@@ -409,9 +409,9 @@ contract RecurringCollector is EIP712, GraphDirectory, Authorizable, IRecurringC
     }
 
     /**
-     * @notice See {IRecurringCollector.hashRCAU712}
+     * @notice See {IRecurringCollector.hashRCAU}
      */
-    function _hashRCAU712(RecurringCollectionAgreementUpdate memory _rcau) private view returns (bytes32) {
+    function _hashRCAU(RecurringCollectionAgreementUpdate memory _rcau) private view returns (bytes32) {
         return
             _hashTypedDataV4(
                 keccak256(

packages/horizon/test/unit/payments/recurring-collector/RecurringCollectorHelper.t.sol

@@ -19,7 +19,7 @@ contract RecurringCollectorHelper is AuthorizableHelper, Bounder {
         IRecurringCollector.RecurringCollectionAgreement memory rca,
         uint256 signerPrivateKey
     ) public view returns (IRecurringCollector.SignedRCA memory) {
-        bytes32 messageHash = collector.hashRCA712(rca);
+        bytes32 messageHash = collector.hashRCA(rca);
         (uint8 v, bytes32 r, bytes32 s) = vm.sign(signerPrivateKey, messageHash);
         bytes memory signature = abi.encodePacked(r, s, v);
         IRecurringCollector.SignedRCA memory signedRCA = IRecurringCollector.SignedRCA({
@@ -34,7 +34,7 @@ contract RecurringCollectorHelper is AuthorizableHelper, Bounder {
         IRecurringCollector.RecurringCollectionAgreementUpdate memory rcau,
         uint256 signerPrivateKey
     ) public view returns (IRecurringCollector.SignedRCAU memory) {
-        bytes32 messageHash = collector.hashRCAU712(rcau);
+        bytes32 messageHash = collector.hashRCAU(rcau);
         (uint8 v, bytes32 r, bytes32 s) = vm.sign(signerPrivateKey, messageHash);
         bytes memory signature = abi.encodePacked(r, s, v);
         IRecurringCollector.SignedRCAU memory signedRCAU = IRecurringCollector.SignedRCAU({