TRST audit fixes for data service contracts #1076
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following findings:
TRST-L-1 DataService cannot be initialized using __DataService_init_unchained() unlike stated in docsTRST-L-13 Allocations could be created with a provision below the minimum valid amountTRST-R-3 Verify state transitionsTRST-R-4 Lack of storage slots in upgradeable contractsTRST-R-5 Equivalent contracts behave differentlyTRST-R-6 Protect from developer errors by improving docs of inheriting contracts