-
Notifications
You must be signed in to change notification settings - Fork 155
docs: update GraphTally docs #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, looks like you updated the file in the wrong language (pages/es
instead of pages/en
). Also, there are weird formatting changes – I recommend running pnpm check:fix
after making changes (but before committing them), if you don't have the Prettier extension installed and format on save enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Minor suggested edits, but LGTM!
- Happy with the reorganization of this 😄
- [Graph TAP Arbitrum One Subgraph (for The Graph mainnet)](https://thegraph.com/explorer/subgraphs/4sukbNVTzGELnhdnpyPqsf1QqtzNHEYKKmJkgaT8z6M1) | ||
|
||
> Note: `indexer-agent` does not currently handle the indexing of this Subgraph like it does for the network Subgraph deployment. As a result, you have to index it manually. | ||
> Note: `indexer-agent` does not currently handle the indexing of this subgraph like it does for the network subgraph deployment. You must index it manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> Note: `indexer-agent` does not currently handle the indexing of this subgraph like it does for the network subgraph deployment. You must index it manually. | |
> Note: `indexer-agent` does not currently handle the indexing of this Subgraph like it does for the network Subgraph deployment. You must index it manually. |
- the style guide will be updated to reflect cap preference
# Locally indexing the Subgraph is recommended. | ||
# NOTE: Use `query_url` or `deployment_id` only | ||
deployment_id = "Qmaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" | ||
# The Graph Network subgraph (use query_url OR deployment_id, not both) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# The Graph Network subgraph (use query_url OR deployment_id, not both) | |
# The Graph Network Subgraph (use query_url OR deployment_id, not both) |
# Locally indexing the Subgraph is recommended. | ||
# NOTE: Use `query_url` or `deployment_id` only | ||
deployment_id = "Qmaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" | ||
# TAP Escrow subgraph (use query_url OR deployment_id, not both) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# TAP Escrow subgraph (use query_url OR deployment_id, not both) | |
# TAP Escrow Subgraph (use query_url OR deployment_id, not both) |
Signed-off-by: Joseph Livesey <[email protected]>
Thanks to @matthewdarwin for flagging the need for an update!
Signed off by Joseph Livesey [email protected]