feat: invert cuts to keep meaning consistent with pre-horizon

Signed-off-by: Tomás Migone <[email protected]>

Author: tmigone

src/mappings/helpers/helpers.ts

@@ -163,13 +163,13 @@ export function createOrLoadIndexer(indexerAddress: Bytes, timestamp: BigInt ):
     indexer.delegatedStakeRatio = BigDecimal.fromString('0')
     indexer.delegatorShares = BigInt.fromI32(0)
     indexer.delegationExchangeRate = BigDecimal.fromString('1')
-    indexer.indexingRewardCut = 0
+    indexer.indexingRewardCut = BigInt.fromI32(1000000)
     indexer.indexingRewardEffectiveCut = BigDecimal.fromString('0')
     indexer.overDelegationDilution = BigDecimal.fromString('0')
     indexer.delegatorIndexingRewards = BigInt.fromI32(0)
     indexer.indexerIndexingRewards = BigInt.fromI32(0)
     indexer.delegatorQueryFees = BigInt.fromI32(0)
-    indexer.queryFeeCut = 0
+    indexer.queryFeeCut = BigInt.fromI32(1000000)
     indexer.queryFeeEffectiveCut = BigDecimal.fromString('0')
     indexer.delegatorParameterCooldown = 0
     indexer.lastDelegationParameterUpdate = 0
@@ -226,9 +226,9 @@ export function createOrLoadProvision(indexerAddress: Bytes, verifierAddress: By
     provision.maxVerifierCutPending = BigInt.fromI32(0)
     provision.thawingPeriod = BigInt.fromI32(0)
     provision.thawingPeriodPending = BigInt.fromI32(0)
-    provision.queryFeeCut = BigInt.fromI32(0)
-    provision.indexingFeeCut = BigInt.fromI32(0)
-    provision.indexingRewardsCut = BigInt.fromI32(0)
+    provision.queryFeeCut = BigInt.fromI32(1000000)
+    provision.indexingFeeCut = BigInt.fromI32(1000000)
+    provision.indexingRewardsCut = BigInt.fromI32(1000000)
     provision.indexingRewardEffectiveCut = BigInt.fromI32(0).toBigDecimal()
     provision.queryFeeEffectiveCut = BigInt.fromI32(0).toBigDecimal()
     provision.overDelegationDilution = BigInt.fromI32(0).toBigDecimal()
@@ -954,25 +954,22 @@ export function calculateDelegatedStakeRatio(indexer: Indexer): BigDecimal {
 }
 
 export function calculateIndexingRewardEffectiveCut(indexer: Indexer): BigDecimal {
-  let delegatorCut =
-    BigInt.fromI32(1000000 - indexer.indexingRewardCut).toBigDecimal() /
-    BigDecimal.fromString('1000000')
+  let delegatorCut = indexer.indexingRewardCut.toBigDecimal() / BigDecimal.fromString('1000000')
   return indexer.delegatedStakeRatio == BigDecimal.fromString('0')
     ? BigDecimal.fromString('0')
     : BigDecimal.fromString('1') - delegatorCut / indexer.delegatedStakeRatio
 }
 
 export function calculateQueryFeeEffectiveCut(indexer: Indexer): BigDecimal {
-  let delegatorCut =
-    BigInt.fromI32(1000000 - indexer.queryFeeCut).toBigDecimal() / BigDecimal.fromString('1000000')
+  let delegatorCut = indexer.queryFeeCut.toBigDecimal() / BigDecimal.fromString('1000000')
   return indexer.delegatedStakeRatio == BigDecimal.fromString('0')
     ? BigDecimal.fromString('0')
     : BigDecimal.fromString('1') - delegatorCut / indexer.delegatedStakeRatio
 }
 
 export function calculateIndexerRewardOwnGenerationRatio(indexer: Indexer): BigDecimal {
   let rewardCut =
-    BigInt.fromI32(indexer.indexingRewardCut).toBigDecimal() / BigDecimal.fromString('1000000')
+    BigInt.fromI32(1000000 -indexer.indexingRewardCut).toBigDecimal() / BigDecimal.fromString('1000000')
   return indexer.ownStakeRatio == BigDecimal.fromString('0')
     ? BigDecimal.fromString('0')
     : rewardCut / indexer.ownStakeRatio
@@ -1017,7 +1014,7 @@ export function calculateDelegatedStakeRatioForProvision(provision: Provision):
 
 export function calculateIndexingRewardEffectiveCutForProvision(provision: Provision): BigDecimal {
   let delegatorCut =
-    provision.indexingRewardsCut.toBigDecimal() /
+    BigInt.fromI32(1000000 - provision.indexingRewardsCut).toBigDecimal() /
     BigDecimal.fromString('1000000')
   return provision.delegatedStakeRatio == BigDecimal.fromString('0')
     ? BigDecimal.fromString('0')
@@ -1026,15 +1023,17 @@ export function calculateIndexingRewardEffectiveCutForProvision(provision: Provi
 
 export function calculateQueryFeeEffectiveCutForProvision(provision: Provision): BigDecimal {
   let delegatorCut =
-    provision.queryFeeCut.toBigDecimal() / BigDecimal.fromString('1000000')
+    BigInt.fromI32(1000000 - provision.queryFeeCut).toBigDecimal() /
+    BigDecimal.fromString('1000000')
   return provision.delegatedStakeRatio == BigDecimal.fromString('0')
     ? BigDecimal.fromString('0')
     : BigDecimal.fromString('1') - delegatorCut / provision.delegatedStakeRatio
 }
 
 export function calculateIndexerRewardOwnGenerationRatioForProvision(provision: Provision): BigDecimal {
   let delegatorCut =
-    provision.indexingRewardsCut.toBigDecimal() / BigDecimal.fromString('1000000')
+    BigInt.fromI32(1000000 - provision.indexingRewardsCut).toBigDecimal() /
+    BigDecimal.fromString('1000000')
   return provision.ownStakeRatio == BigDecimal.fromString('0')
     ? BigDecimal.fromString('0')
     : (BigDecimal.fromString('1') - delegatorCut) / provision.ownStakeRatio
@@ -1212,7 +1211,7 @@ export function batchUpdateSubgraphSignalledTokens(deployment: SubgraphDeploymen
   }
 }
 
-export function convertBigIntSubgraphIDToBase58(bigIntRepresentation: BigInt): String {
+export function convertBigIntSubgraphIDToBase58(bigIntRepresentation: BigInt): string {
   // Might need to unpad the BigInt since `fromUnsignedBytes` pads one byte with a zero.
   // Although for the events where the uint256 is provided, we probably don't need to unpad.
   let hexString = bigIntRepresentation.toHexString()

src/mappings/horizonStaking.ts

@@ -218,10 +218,21 @@ export function handleOperatorSet(event: OperatorSet): void {
 
 export function handleDelegationFeeCutSet(event: DelegationFeeCutSet): void {
     let provision = createOrLoadProvision(event.params.serviceProvider, event.params.verifier, event.block.timestamp)
-    provision.queryFeeCut = event.params.paymentType == 0 ? event.params.feeCut : provision.queryFeeCut
-    provision.indexingFeeCut = event.params.paymentType == 1 ? event.params.feeCut : provision.indexingFeeCut
-    provision.indexingRewardsCut = event.params.paymentType == 2 ? event.params.feeCut : provision.indexingRewardsCut
+    
+    // Before horizon the cuts represented how much the indexer took home. After horizon they now represent how much the delegators get
+    // To avoid confusion and more changes on explorer we invert the meaning here to keep it consistent.
+    let invertedCut = BigInt.fromI32(1_000_000).minus(event.params.feeCut)
+    provision.queryFeeCut = event.params.paymentType == 0 ? invertedCut : provision.queryFeeCut
+    provision.indexingFeeCut = event.params.paymentType == 1 ? invertedCut : provision.indexingFeeCut
+    provision.indexingRewardsCut = event.params.paymentType == 2 ? invertedCut : provision.indexingRewardsCut
+    provision = updateAdvancedProvisionMetrics(provision as Provision)
     provision.save()
+
+    let indexer = Indexer.load(event.params.serviceProvider.toHexString())!
+    indexer.indexingRewardCut = event.params.paymentType == 2 ? invertedCut : indexer.indexingRewardCut
+    indexer.queryFeeCut = event.params.paymentType == 0 ? invertedCut : indexer.queryFeeCut
+    indexer = updateAdvancedIndexerMetrics(indexer as Indexer)
+    indexer.save()
 }
 
 export function handleProvisionSlashed(event: ProvisionSlashed): void {

src/mappings/staking.ts

@@ -51,19 +51,6 @@ import {
 } from './helpers/helpers'
 import { addresses } from '../../config/addresses'
 
-export function handleDelegationParametersUpdated(event: DelegationParametersUpdated): void {
-  let graphNetwork = createOrLoadGraphNetwork(event.block.number, event.address)
-  let indexer = createOrLoadLegacyIndexer(event.params.indexer, event.block.timestamp)
-  indexer.indexingRewardCut = event.params.indexingRewardCut.toI32()
-  indexer.queryFeeCut = event.params.queryFeeCut.toI32()
-  indexer.delegatorParameterCooldown = event.params.cooldownBlocks.toI32()
-  indexer.lastDelegationParameterUpdate = (
-    addresses.isL1 ? event.block.number : graphNetwork.currentL1BlockNumber!
-  ).toI32()
-  indexer = updateAdvancedIndexerMetrics(indexer as Indexer)
-  indexer.save()
-}
-
 /**
  * @dev handleStakeDeposited
  * - creates an Indexer if it is the first time they have staked

subgraph.template.yaml

@@ -317,8 +317,6 @@ dataSources:
         - name: EpochManager
           file: ./node_modules/@graphprotocol/contracts/dist/abis/EpochManager.json
       eventHandlers:
-        - event: DelegationParametersUpdated(indexed address,uint32,uint32,uint32)
-          handler: handleDelegationParametersUpdated
         - event: StakeDeposited(indexed address,uint256)
           handler: handleStakeDeposited
         - event: StakeLocked(indexed address,uint256,uint256)