fix: comments from latest round of reviews

Author: juanmardefago

schema.graphql

@@ -234,7 +234,7 @@ type GraphNetwork @entity {
 }
 
 type DataService @entity {
-  "Verifier address"
+  "Data Service address"
   id: ID!
 
   "Total GRT currently in provisions for this DataService"
@@ -687,7 +687,7 @@ type Indexer @entity {
   # Staking data
   "CURRENT tokens staked in the protocol. Decreases on withdraw, not on lock"
   stakedTokens: BigInt!
-  "CURRENT tokens provisioned to data services in the protocol. In the V1 protocol, all staked tokens were always provisioned since there was only one data service"
+  "CURRENT tokens provisioned to data services in the protocol. In the V1 protocol, all staked tokens were always provisioned to an implicit 'subgraph data service'"
   provisionedTokens: BigInt!
   "CURRENT  tokens allocated on all subgraphs"
   allocatedTokens: BigInt!
@@ -830,12 +830,12 @@ type IndexerQueryFeePaymentAggregation @entity {
 }
 
 type Provision @entity {
-  "Join ID of indexer address (service provider) and DataService address (verifier)"
+  "Join ID of indexer address (service provider) and DataService address"
   id: ID!
 
   indexer: Indexer!
 
-  service: DataService!
+  dataService: DataService!
 
   tokensProvisioned: BigInt!
 }

src/mappings/staking.ts

@@ -76,14 +76,12 @@ export function handleStakeDeposited(event: StakeDeposited): void {
   let indexer = createOrLoadIndexer(event.params.indexer, event.block.timestamp)
   let previousStake = indexer.stakedTokens
   indexer.stakedTokens = indexer.stakedTokens.plus(event.params.tokens)
-  indexer.provisionedTokens = indexer.provisionedTokens.plus(event.params.tokens)
   indexer = updateAdvancedIndexerMetrics(indexer as Indexer)
   indexer = calculateCapacities(indexer as Indexer)
   indexer.save()
 
   // Update graph network
   graphNetwork.totalTokensStaked = graphNetwork.totalTokensStaked.plus(event.params.tokens)
-  graphNetwork.totalTokensProvisioned = graphNetwork.totalTokensProvisioned.plus(event.params.tokens)
   if (previousStake == BigInt.fromI32(0)) {
     graphNetwork.stakedIndexersCount = graphNetwork.stakedIndexersCount + 1
   }
@@ -138,7 +136,6 @@ export function handleStakeWithdrawn(event: StakeWithdrawn): void {
   let id = event.params.indexer.toHexString()
   let indexer = Indexer.load(id)!
   indexer.stakedTokens = indexer.stakedTokens.minus(event.params.tokens)
-  indexer.provisionedTokens = indexer.provisionedTokens.minus(event.params.tokens)
   indexer.lockedTokens = indexer.lockedTokens.minus(event.params.tokens)
   indexer.tokensLockedUntil = 0 // always set to 0 when withdrawn
   indexer = updateAdvancedIndexerMetrics(indexer as Indexer)
@@ -147,7 +144,6 @@ export function handleStakeWithdrawn(event: StakeWithdrawn): void {
 
   // Update graph network
   graphNetwork.totalTokensStaked = graphNetwork.totalTokensStaked.minus(event.params.tokens)
-  graphNetwork.totalTokensProvisioned = graphNetwork.totalTokensProvisioned.minus(event.params.tokens)
   graphNetwork.totalUnstakedTokensLocked = graphNetwork.totalUnstakedTokensLocked.minus(
     event.params.tokens,
   )