server: Add test helper function to ensure CORS headers are set right

tilacog · tilacog · commit 0f33f0f918ba · 2021-02-24T13:20:48.000-03:00
diff --git a/server/http/src/test_utils.rs b/server/http/src/test_utils.rs
@@ -1,14 +1,14 @@
 use graph::prelude::serde_json;
 use graph::prelude::*;
 use http::StatusCode;
-use hyper::{Body, Response};
+use hyper::{header::ACCESS_CONTROL_ALLOW_ORIGIN, Body, Response};
 
 /// Asserts that the response is a successful GraphQL response; returns its `"data"` field.
 pub fn assert_successful_response(
     response: Response<Body>,
 ) -> serde_json::Map<String, serde_json::Value> {
     assert_eq!(response.status(), StatusCode::OK);
-
+    assert_expected_headers(&response);
     futures03::executor::block_on(
         hyper::body::to_bytes(response.into_body())
             .map_ok(|chunk| {
@@ -35,7 +35,7 @@ pub fn assert_error_response(
     graphql_response: bool,
 ) -> Vec<serde_json::Value> {
     assert_eq!(response.status(), expected_status);
-
+    assert_expected_headers(&response);
     let body = String::from_utf8(
         futures03::executor::block_on(hyper::body::to_bytes(response.into_body()))
             .unwrap()
@@ -59,3 +59,13 @@ pub fn assert_error_response(
         .expect("GraphQL \"errors\" field must be a vector")
         .clone()
 }
+
+pub fn assert_expected_headers(response: &Response<Body>) {
+    assert_eq!(
+        response
+            .headers()
+            .get(ACCESS_CONTROL_ALLOW_ORIGIN)
+            .expect("Missing CORS Header"),
+        &"*"
+    );
+}
diff --git a/server/http/tests/response.rs b/server/http/tests/response.rs
@@ -8,13 +8,15 @@ use std::collections::BTreeMap;
 fn generates_200_for_query_results() {
     let data = BTreeMap::new();
     let query_result = QueryResults::from(data).as_http_response();
+    test_utils::assert_expected_headers(&query_result);
     test_utils::assert_successful_response(query_result);
 }
 
 #[test]
 fn generates_valid_json_for_an_empty_result() {
     let data = BTreeMap::new();
     let query_result = QueryResults::from(data).as_http_response();
+    test_utils::assert_expected_headers(&query_result);
     let data = test_utils::assert_successful_response(query_result);
     assert!(data.is_empty());
 }
