chain/ethereum: remove unused block_hash_by_block_number method

Author: incrypto32

chain/ethereum/src/adapter.rs

@@ -1124,21 +1124,6 @@ pub trait EthereumAdapter: Send + Sync + 'static {
         block: LightEthereumBlock,
     ) -> Result<EthereumBlock, bc::IngestorError>;
 
-    /// Find a block by its number, according to the Ethereum node.
-    ///
-    /// Careful: don't use this function without considering race conditions.
-    /// Chain reorgs could happen at any time, and could affect the answer received.
-    /// Generally, it is only safe to use this function with blocks that have received enough
-    /// confirmations to guarantee no further reorgs, **and** where the Ethereum node is aware of
-    /// those confirmations.
-    /// If the Ethereum node is far behind in processing blocks, even old blocks can be subject to
-    /// reorgs.
-    async fn block_hash_by_block_number(
-        &self,
-        logger: &Logger,
-        block_number: BlockNumber,
-    ) -> Result<Option<H256>, Error>;
-
     /// Finds the hash and number of the lowest non-null block with height greater than or equal to
     /// the given number.
     ///

chain/ethereum/src/ethereum_adapter.rs

@@ -1475,41 +1475,6 @@ impl EthereumAdapterTrait for EthereumAdapter {
             })
     }
 
-    async fn block_hash_by_block_number(
-        &self,
-        logger: &Logger,
-        block_number: BlockNumber,
-    ) -> Result<Option<H256>, Error> {
-        let web3 = self.web3.clone();
-        let retry_log_message = format!(
-            "eth_getBlockByNumber RPC call for block number {}",
-            block_number
-        );
-        retry(retry_log_message, logger)
-            .redact_log_urls(true)
-            .no_limit()
-            .timeout_secs(ENV_VARS.json_rpc_timeout.as_secs())
-            .run(move || {
-                let web3 = web3.cheap_clone();
-                async move {
-                    web3.eth()
-                        .block(BlockId::Number(block_number.into()))
-                        .await
-                        .map(|block_opt| block_opt.and_then(|block| block.hash))
-                        .map_err(Error::from)
-                }
-            })
-            .await
-            .map_err(move |e| {
-                e.into_inner().unwrap_or_else(move || {
-                    anyhow!(
-                        "Ethereum node took too long to return data for block #{}",
-                        block_number
-                    )
-                })
-            })
-    }
-
     async fn get_balance(
         &self,
         logger: &Logger,