server: improve warning message for graphman graphql api and clean up code

Author: shiyasmohd

server/graphman/src/entities/warning_response.rs

@@ -6,8 +6,7 @@ pub struct CompletedWithWarnings {
 }
 
 impl CompletedWithWarnings {
-    /// Returns a response with success & message.
-    pub fn new(msg: Vec<String>) -> Self {
-        Self { warnings: msg }
+    pub fn new(warnings: Vec<String>) -> Self {
+        Self { warnings }
     }
 }

server/graphman/src/resolvers/deployment_mutation.rs

@@ -20,6 +20,7 @@ mod reassign;
 mod restart;
 mod resume;
 mod unassign;
+
 pub struct DeploymentMutation;
 
 #[derive(Clone, Debug, Union)]
@@ -107,7 +108,7 @@ impl DeploymentMutation {
         let mirror = catalog::Mirror::primary_only(ctx.primary_pool);
         let count = mirror.assignments(&node)?.len();
         if count == 1 {
-            let warning_msg = format!("warning: this is the only deployment assigned to '{}'. Are you sure it is spelled correctly?",node.as_str());
+            let warning_msg = format!("This is the only deployment assigned to '{}'. Please make sure that the node ID is spelled correctly.",node.as_str());
             Ok(ReassignResponse::CompletedWithWarnings(
                 CompletedWithWarnings::new(vec![warning_msg]),
             ))

server/graphman/tests/deployment_mutation.rs

@@ -266,8 +266,6 @@ fn graphql_allows_tracking_restart_deployment_executions() {
         assert_eq!(resp, expected_resp);
     });
 }
-<<<<<<< HEAD
-=======
 
 #[test]
 fn graphql_can_create_new_subgraph() {
@@ -425,7 +423,7 @@ fn graphql_can_unassign_deployments() {
 
         let subgraph_node_id = send_graphql_request(
             json!({
-                "query": r#"query Deployment {
+                "query": r#"{
                     deployment {
                         info(deployment: { hash: "subgraph_1" }) {
                             nodeId
@@ -586,4 +584,3 @@ fn graphql_warns_reassign_on_wrong_node_id() {
         assert_eq!(reassign, expected_resp);
     });
 }
->>>>>>> 5ab559557 (server: graphman graphql api tests added for unassign/reassign)