Limit big int (#4594)

* runtime, graph: Limit bigint size

* fix(runtime): make gas complexity of big int and decimal quadratic

Author: leoyvens

chain/ethereum/src/runtime/abi.rs

@@ -489,7 +489,7 @@ impl ToAscObj<AscEthereumTransaction_0_0_1> for EthereumTransactionData {
     ) -> Result<AscEthereumTransaction_0_0_1, HostExportError> {
         Ok(AscEthereumTransaction_0_0_1 {
             hash: asc_new(heap, &self.hash, gas)?,
-            index: asc_new(heap, &BigInt::from(self.index), gas)?,
+            index: asc_new(heap, &BigInt::from_unsigned_u128(self.index), gas)?,
             from: asc_new(heap, &self.from, gas)?,
             to: self
                 .to
@@ -510,7 +510,7 @@ impl ToAscObj<AscEthereumTransaction_0_0_2> for EthereumTransactionData {
     ) -> Result<AscEthereumTransaction_0_0_2, HostExportError> {
         Ok(AscEthereumTransaction_0_0_2 {
             hash: asc_new(heap, &self.hash, gas)?,
-            index: asc_new(heap, &BigInt::from(self.index), gas)?,
+            index: asc_new(heap, &BigInt::from_unsigned_u128(self.index), gas)?,
             from: asc_new(heap, &self.from, gas)?,
             to: self
                 .to
@@ -532,7 +532,7 @@ impl ToAscObj<AscEthereumTransaction_0_0_6> for EthereumTransactionData {
     ) -> Result<AscEthereumTransaction_0_0_6, HostExportError> {
         Ok(AscEthereumTransaction_0_0_6 {
             hash: asc_new(heap, &self.hash, gas)?,
-            index: asc_new(heap, &BigInt::from(self.index), gas)?,
+            index: asc_new(heap, &BigInt::from_unsigned_u128(self.index), gas)?,
             from: asc_new(heap, &self.from, gas)?,
             to: self
                 .to

graph/examples/stress.rs

@@ -249,7 +249,7 @@ impl Template for BigInt {
             }
             None => 1,
         };
-        BigInt::from(3u64).pow(size as u8) * BigInt::from(f)
+        BigInt::from(3u64).pow(size as u8).unwrap() * BigInt::from(f)
     }
 
     fn sample(&self, size: usize, rng: Option<&mut SmallRng>) -> Box<Self> {
@@ -274,7 +274,7 @@ impl Template for BigDecimal {
             Some(rng) => rng.gen_range(-100..=100),
             None => 1,
         };
-        let bi = BigInt::from(3u64).pow(size as u8) * BigInt::from(f);
+        let bi = BigInt::from(3u64).pow(size as u8).unwrap() * BigInt::from(f);
         BigDecimal::new(bi, exp)
     }
 

graph/src/data/query/error.rs

@@ -1,6 +1,5 @@
 use graphql_parser::Pos;
 use hex::FromHexError;
-use num_bigint;
 use serde::ser::*;
 use std::collections::HashMap;
 use std::error::Error;
@@ -292,12 +291,6 @@ impl From<FromHexError> for QueryExecutionError {
     }
 }
 
-impl From<num_bigint::ParseBigIntError> for QueryExecutionError {
-    fn from(e: num_bigint::ParseBigIntError) -> Self {
-        QueryExecutionError::ValueParseError("BigInt".to_string(), format!("{}", e))
-    }
-}
-
 impl From<bigdecimal::ParseBigDecimalError> for QueryExecutionError {
     fn from(e: bigdecimal::ParseBigDecimalError) -> Self {
         QueryExecutionError::ValueParseError("BigDecimal".to_string(), format!("{}", e))

graph/src/data/store/ethereum.rs

@@ -1,12 +1,6 @@
 use super::scalar;
 use crate::prelude::*;
-use web3::types::{Address, Bytes, H2048, H256, H64, U128, U256, U64};
-
-impl From<U128> for Value {
-    fn from(n: U128) -> Value {
-        Value::BigInt(scalar::BigInt::from_signed_u256(&n.into()))
-    }
-}
+use web3::types::{Address, Bytes, H2048, H256, H64, U64};
 
 impl From<Address> for Value {
     fn from(address: Address) -> Value {
@@ -43,9 +37,3 @@ impl From<U64> for Value {
         Value::BigInt(BigInt::from(n))
     }
 }
-
-impl From<U256> for Value {
-    fn from(n: U256) -> Value {
-        Value::BigInt(BigInt::from_unsigned_u256(&n))
-    }
-}

graph/src/data/store/mod.rs

@@ -313,7 +313,9 @@ impl Value {
                 // just a string.
                 match n.as_str() {
                     BYTES_SCALAR => Value::Bytes(scalar::Bytes::from_str(s)?),
-                    BIG_INT_SCALAR => Value::BigInt(scalar::BigInt::from_str(s)?),
+                    BIG_INT_SCALAR => Value::BigInt(scalar::BigInt::from_str(s).map_err(|e| {
+                        QueryExecutionError::ValueParseError("BigInt".to_string(), format!("{}", e))
+                    })?),
                     BIG_DECIMAL_SCALAR => Value::BigDecimal(scalar::BigDecimal::from_str(s)?),
                     _ => Value::String(s.clone()),
                 }