all: Simplify return type of SubgraphAssignmentProvider.stop

The method would never fil, so no reason to use a `Result`

Author: lutter

core/src/subgraph/provider.rs

@@ -91,15 +91,11 @@ impl<I: SubgraphInstanceManager> SubgraphAssignmentProviderTrait for SubgraphAss
         );
     }
 
-    async fn stop(
-        &self,
-        deployment: DeploymentLocator,
-    ) -> Result<(), SubgraphAssignmentProviderError> {
+    async fn stop(&self, deployment: DeploymentLocator) {
         // If subgraph ID was in set
         if self.deployment_registry.remove(&deployment.id) {
             // Shut down subgraph processing
             self.instance_manager.stop_subgraph(deployment).await;
         }
-        Ok(())
     }
 }

core/src/subgraph/registrar.rs

@@ -472,18 +472,13 @@ async fn handle_assignment_event(
         AssignmentEvent::Add {
             deployment,
             node_id: _,
-        } => {
-            provider.start(deployment, None).await;
-            Ok(())
-        }
+        } => provider.start(deployment, None).await,
         AssignmentEvent::Remove {
             deployment,
             node_id: _,
-        } => match provider.stop(deployment).await {
-            Ok(()) => Ok(()),
-            Err(e) => Err(CancelableError::Error(e)),
-        },
+        } => provider.stop(deployment).await,
     }
+    Ok(())
 }
 
 /// Resolves the subgraph's earliest block

graph/src/components/subgraph/provider.rs

@@ -6,8 +6,5 @@ use crate::{components::store::DeploymentLocator, prelude::*};
 #[async_trait]
 pub trait SubgraphAssignmentProvider: Send + Sync + 'static {
     async fn start(&self, deployment: DeploymentLocator, stop_block: Option<BlockNumber>);
-    async fn stop(
-        &self,
-        deployment: DeploymentLocator,
-    ) -> Result<(), SubgraphAssignmentProviderError>;
+    async fn stop(&self, deployment: DeploymentLocator);
 }

tests/src/fixture/mod.rs

@@ -282,7 +282,7 @@ impl TestContext {
 
     pub async fn start_and_sync_to(&self, stop_block: BlockPtr) {
         // In case the subgraph has been previously started.
-        self.provider.stop(self.deployment.clone()).await.unwrap();
+        self.provider.stop(self.deployment.clone()).await;
 
         self.provider
             .start(self.deployment.clone(), Some(stop_block.number))
@@ -302,7 +302,7 @@ impl TestContext {
 
     pub async fn start_and_sync_to_error(&self, stop_block: BlockPtr) -> SubgraphError {
         // In case the subgraph has been previously started.
-        self.provider.stop(self.deployment.clone()).await.unwrap();
+        self.provider.stop(self.deployment.clone()).await;
 
         self.provider.start(self.deployment.clone(), None).await;
 

tests/tests/runner_tests.rs

@@ -82,11 +82,7 @@ async fn data_source_revert() -> anyhow::Result<()> {
 
     let stop_block = test_ptr(2);
     base_ctx.start_and_sync_to(stop_block).await;
-    base_ctx
-        .provider
-        .stop(base_ctx.deployment.clone())
-        .await
-        .unwrap();
+    base_ctx.provider.stop(base_ctx.deployment.clone()).await;
 
     // Test loading data sources from DB.
     let stop_block = test_ptr(3);