data source: Move MAX_API_VERSION check

Author: leoyvens

chain/ethereum/src/data_source.rs

@@ -15,9 +15,9 @@ use web3::types::{Log, Transaction, H256};
 use graph::{
     blockchain::{self, Blockchain},
     prelude::{
-        async_trait, info, lazy_static, serde_json, BlockNumber, CheapClone,
-        DataSourceTemplateInfo, Deserialize, EthereumCall, LightEthereumBlock,
-        LightEthereumBlockExt, LinkResolver, Logger, TryStreamExt,
+        async_trait, info, serde_json, BlockNumber, CheapClone, DataSourceTemplateInfo,
+        Deserialize, EthereumCall, LightEthereumBlock, LightEthereumBlockExt, LinkResolver, Logger,
+        TryStreamExt,
     },
 };
 
@@ -26,13 +26,6 @@ use graph::data::subgraph::{calls_host_fn, DataSourceContext, Source};
 use crate::chain::Chain;
 use crate::trigger::{EthereumBlockTriggerType, EthereumTrigger, MappingTrigger};
 
-lazy_static! {
-    static ref MAX_API_VERSION: semver::Version = std::env::var("GRAPH_MAX_API_VERSION")
-        .ok()
-        .and_then(|api_version_str| semver::Version::parse(&api_version_str).ok())
-        .unwrap_or(semver::Version::new(0, 0, 5));
-}
-
 /// Runtime representation of a data source.
 // Note: Not great for memory usage that this needs to be `Clone`, considering how there may be tens
 // of thousands of data sources in memory at once.
@@ -867,19 +860,10 @@ impl UnresolvedMapping {
             file: link,
         } = self;
 
-        let api_version = semver::Version::parse(&api_version)?;
-
-        ensure!(
-            semver::VersionReq::parse(&format!("<= {}", *MAX_API_VERSION))
-                .unwrap()
-                .matches(&api_version),
-            "The maximum supported mapping API version of this indexer is {}, but `{}` was found",
-            *MAX_API_VERSION,
-            api_version
-        );
-
         info!(logger, "Resolve mapping"; "link" => &link.link);
 
+        let api_version = semver::Version::parse(&api_version)?;
+
         let (abis, runtime) = try_join(
             // resolve each abi
             abis.into_iter()

graph/src/data/subgraph/mod.rs

@@ -1,3 +1,4 @@
+use anyhow::ensure;
 use anyhow::{anyhow, Error};
 use futures03::{future::try_join3, stream::FuturesOrdered, TryStreamExt as _};
 use itertools::Itertools;
@@ -60,6 +61,10 @@ lazy_static! {
         .ok()
         .and_then(|api_version_str| Version::parse(&api_version_str).ok())
         .unwrap_or(SPEC_VERSION_0_0_3);
+    static ref MAX_API_VERSION: semver::Version = std::env::var("GRAPH_MAX_API_VERSION")
+        .ok()
+        .and_then(|api_version_str| semver::Version::parse(&api_version_str).ok())
+        .unwrap_or(semver::Version::new(0, 0, 5));
 }
 
 /// Rust representation of the GraphQL schema for a `SubgraphManifest`.
@@ -790,6 +795,17 @@ impl<C: Blockchain> UnresolvedSubgraphManifest<C> {
         )
         .await?;
 
+        for ds in &data_sources {
+            ensure!(
+                semver::VersionReq::parse(&format!("<= {}", *MAX_API_VERSION))
+                    .unwrap()
+                    .matches(&ds.api_version()),
+                "The maximum supported mapping API version of this indexer is {}, but `{}` was found",
+                *MAX_API_VERSION,
+                ds.api_version()
+            );
+        }
+
         Ok(SubgraphManifest {
             id,
             spec_version,