node,server: improve error handling when restarting paused subgraphs

Author: shiyasmohd

node/src/manager/commands/deployment/pause.rs

@@ -3,20 +3,32 @@ use std::sync::Arc;
 use anyhow::Result;
 use graph_store_postgres::connection_pool::ConnectionPool;
 use graph_store_postgres::NotificationSender;
-use graphman::commands::deployment::pause::load_active_deployment;
-use graphman::commands::deployment::pause::pause_active_deployment;
+use graphman::commands::deployment::pause::{
+    load_active_deployment, pause_active_deployment, PauseDeploymentError,
+};
 use graphman::deployment::DeploymentSelector;
 
 pub fn run(
     primary_pool: ConnectionPool,
     notification_sender: Arc<NotificationSender>,
     deployment: DeploymentSelector,
 ) -> Result<()> {
-    let active_deployment = load_active_deployment(primary_pool.clone(), &deployment)?;
+    let active_deployment = load_active_deployment(primary_pool.clone(), &deployment);
 
-    println!("Pausing deployment {} ...", active_deployment.locator());
-
-    pause_active_deployment(primary_pool, notification_sender, active_deployment)?;
+    match active_deployment {
+        Ok(active_deployment) => {
+            println!("Pausing deployment {} ...", active_deployment.locator());
+            pause_active_deployment(primary_pool, notification_sender, active_deployment)?;
+        }
+        Err(PauseDeploymentError::AlreadyPaused(locator)) => {
+            println!("Deployment {} is already paused", locator);
+            return Ok(());
+        }
+        Err(PauseDeploymentError::Common(e)) => {
+            println!("Failed to load active deployment: {}", e);
+            return Err(e.into());
+        }
+    }
 
     Ok(())
 }

server/graphman/src/resolvers/deployment_mutation/pause.rs

@@ -1,18 +1,29 @@
 use async_graphql::Result;
-use graphman::commands::deployment::pause::load_active_deployment;
-use graphman::commands::deployment::pause::pause_active_deployment;
+use graphman::commands::deployment::pause::{
+    load_active_deployment, pause_active_deployment, PauseDeploymentError,
+};
 use graphman::deployment::DeploymentSelector;
 
 use crate::resolvers::context::GraphmanContext;
 
 pub fn run(ctx: &GraphmanContext, deployment: &DeploymentSelector) -> Result<()> {
-    let active_deployment = load_active_deployment(ctx.primary_pool.clone(), deployment)?;
+    let active_deployment = load_active_deployment(ctx.primary_pool.clone(), deployment);
 
-    pause_active_deployment(
-        ctx.primary_pool.clone(),
-        ctx.notification_sender.clone(),
-        active_deployment,
-    )?;
+    match active_deployment {
+        Ok(active_deployment) => {
+            pause_active_deployment(
+                ctx.primary_pool.clone(),
+                ctx.notification_sender.clone(),
+                active_deployment,
+            )?;
+        }
+        Err(PauseDeploymentError::AlreadyPaused(_)) => {
+            return Ok(());
+        }
+        Err(PauseDeploymentError::Common(e)) => {
+            return Err(e.into());
+        }
+    }
 
     Ok(())
 }