node: enable extended blocks checks for all chains by default

Author: isum

graph/src/components/network_provider/extended_blocks_check.rs

@@ -13,13 +13,13 @@ use crate::components::network_provider::ProviderName;
 
 /// Requires providers to support extended block details.
 pub struct ExtendedBlocksCheck {
-    enabled_for_chains: HashSet<ChainName>,
+    disabled_for_chains: HashSet<ChainName>,
 }
 
 impl ExtendedBlocksCheck {
-    pub fn new(enabled_for_chains: impl IntoIterator<Item = ChainName>) -> Self {
+    pub fn new(disabled_for_chains: impl IntoIterator<Item = ChainName>) -> Self {
         Self {
-            enabled_for_chains: enabled_for_chains.into_iter().collect(),
+            disabled_for_chains: disabled_for_chains.into_iter().collect(),
         }
     }
 }
@@ -33,7 +33,7 @@ impl ProviderCheck for ExtendedBlocksCheck {
         provider_name: &ProviderName,
         adapter: &dyn NetworkDetails,
     ) -> ProviderCheckStatus {
-        if !self.enabled_for_chains.contains(chain_name) {
+        if self.disabled_for_chains.contains(chain_name) {
             return ProviderCheckStatus::Valid;
         }
 

graph/src/env/mod.rs

@@ -227,13 +227,17 @@ pub struct EnvVars {
     /// If not specified, the graphman server will not start.
     pub graphman_server_auth_token: Option<String>,
 
-    /// If enabled for a chain, requires providers to support extended block details.
+    /// By default, all providers are required to support extended block details,
+    /// as this is the safest option for a graph-node operator.
     ///
-    /// Providers that do not support extended block details for enabled chains are
-    /// considered invalid and will not be used.
+    /// Providers that do not support extended block details for enabled chains
+    /// are considered invalid and will not be used.
     ///
-    /// Defaults to an empty list;
-    pub firehose_require_extended_blocks_for_chains: Vec<String>,
+    /// To disable checks for one or more chains, simply specify their names
+    /// in this configuration option.
+    ///
+    /// Defaults to an empty list, which means that this feature is enabled for all chains;
+    pub firehose_disable_extended_blocks_for_chains: Vec<String>,
 }
 
 impl EnvVars {
@@ -319,9 +323,9 @@ impl EnvVars {
             genesis_validation_enabled: inner.genesis_validation_enabled.0,
             genesis_validation_timeout: Duration::from_secs(inner.genesis_validation_timeout),
             graphman_server_auth_token: inner.graphman_server_auth_token,
-            firehose_require_extended_blocks_for_chains:
-                Self::firehose_require_extended_blocks_for_chains(
-                    inner.firehose_require_extended_blocks_for_chains,
+            firehose_disable_extended_blocks_for_chains:
+                Self::firehose_disable_extended_blocks_for_chains(
+                    inner.firehose_disable_extended_blocks_for_chains,
                 ),
         })
     }
@@ -348,7 +352,7 @@ impl EnvVars {
         self.log_query_timing_contains("cache") && self.log_gql_timing()
     }
 
-    fn firehose_require_extended_blocks_for_chains(s: Option<String>) -> Vec<String> {
+    fn firehose_disable_extended_blocks_for_chains(s: Option<String>) -> Vec<String> {
         s.unwrap_or_default()
             .split(",")
             .map(|x| x.trim().to_string())
@@ -482,8 +486,8 @@ struct Inner {
     genesis_validation_timeout: u64,
     #[envconfig(from = "GRAPHMAN_SERVER_AUTH_TOKEN")]
     graphman_server_auth_token: Option<String>,
-    #[envconfig(from = "GRAPH_NODE_FIREHOSE_REQUIRE_EXTENDED_BLOCKS_FOR_CHAINS")]
-    firehose_require_extended_blocks_for_chains: Option<String>,
+    #[envconfig(from = "GRAPH_NODE_FIREHOSE_DISABLE_EXTENDED_BLOCKS_FOR_CHAINS")]
+    firehose_disable_extended_blocks_for_chains: Option<String>,
 }
 
 #[derive(Clone, Debug)]

node/src/main.rs

@@ -284,17 +284,12 @@ async fn main() {
             )));
         }
 
-        if !env_vars
-            .firehose_require_extended_blocks_for_chains
-            .is_empty()
-        {
-            provider_checks.push(Arc::new(network_provider::ExtendedBlocksCheck::new(
-                env_vars
-                    .firehose_require_extended_blocks_for_chains
-                    .iter()
-                    .map(|x| x.as_str().into()),
-            )));
-        }
+        provider_checks.push(Arc::new(network_provider::ExtendedBlocksCheck::new(
+            env_vars
+                .firehose_disable_extended_blocks_for_chains
+                .iter()
+                .map(|x| x.as_str().into()),
+        )));
 
         let network_adapters = Networks::from_config(
             logger.cheap_clone(),