Skip to content

Commit fe01910

Browse files
committed
graphql: Remove some unecessary clones
1 parent 89103dc commit fe01910

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

graph/src/data/store/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ impl fmt::Display for Value {
364364
impl From<Value> for query::Value {
365365
fn from(value: Value) -> Self {
366366
match value {
367-
Value::String(s) => query::Value::String(s.to_string()),
367+
Value::String(s) => query::Value::String(s),
368368
Value::Int(i) => query::Value::Int(query::Number::from(i)),
369369
Value::BigDecimal(d) => query::Value::String(d.to_string()),
370370
Value::Bool(b) => query::Value::Boolean(b),
@@ -558,8 +558,8 @@ impl DerefMut for Entity {
558558
impl From<Entity> for BTreeMap<String, query::Value> {
559559
fn from(entity: Entity) -> BTreeMap<String, query::Value> {
560560
let mut fields = BTreeMap::new();
561-
for (attr, value) in entity.iter() {
562-
fields.insert(attr.to_string(), value.clone().into());
561+
for (attr, value) in entity.0.into_iter() {
562+
fields.insert(attr, value.into());
563563
}
564564
fields
565565
}

graphql/src/store/resolver.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -202,11 +202,7 @@ where
202202
derived_from_field.name.to_owned(),
203203
));
204204
} else {
205-
return Ok(children
206-
.into_iter()
207-
.next()
208-
.map(|value| value.clone())
209-
.unwrap_or(q::Value::Null));
205+
return Ok(children.into_iter().next().unwrap_or(q::Value::Null));
210206
}
211207
} else {
212208
return Err(QueryExecutionError::ResolveEntitiesError(format!(

0 commit comments

Comments
 (0)