migrate eslint, fix lint warnings

YaroShkvorets · YaroShkvorets · commit 2e7a9e932481 · 2024-12-07T13:49:57.000-05:00
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
diff --git a/eslint.config.js b/eslint.config.js
@@ -0,0 +1,66 @@
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { FlatCompat } from '@eslint/eslintrc';
+import js from '@eslint/js';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all,
+});
+
+export default [
+  {
+    ignores: [
+      '**/node_modules',
+      '**/dist',
+      '**/build',
+      '**/generated',
+      'packages/cli/tests/cli/init',
+      'packages/cli/tests/cli/validation',
+      'packages/ts/test/',
+      '**/examples',
+      '**/vitest.config.ts',
+    ],
+  },
+  ...compat.extends('@theguild'),
+  {
+    rules: {
+      'import/extensions': 'off',
+      'unicorn/no-array-push-push': 'off',
+      'import/no-default-export': 'off',
+      '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/ban-types': 'off',
+      eqeqeq: 'off',
+      '@typescript-eslint/no-unused-vars': 'off',
+    },
+  },
+  {
+    files: ['packages/ts/**'],
+
+    rules: {
+      '@typescript-eslint/no-namespace': 'off',
+      'sonarjs/no-inverted-boolean-check': 'off',
+      'no-loss-of-precision': 'warn',
+    },
+  },
+  {
+    files: ['packages/cli/**'],
+
+    rules: {
+      'no-restricted-imports': [
+        'error',
+        {
+          patterns: [
+            {
+              group: ['@whatwg-node/fetch'],
+              message: 'Please use `fetch` from `./packages/cli/src/fetch.ts`.',
+            },
+          ],
+        },
+      ],
+    },
+  },
+];
diff --git a/package.json b/package.json
@@ -1,5 +1,6 @@
 {
   "name": "graphprotocol-tools-monorepo",
+  "type": "module",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/graphprotocol/graph-cli"
@@ -17,8 +18,8 @@
   "scripts": {
     "build": "pnpm --filter=@graphprotocol/graph-* build",
     "lint": "pnpm lint:prettier && pnpm lint:eslint",
-    "lint:eslint": "ESLINT_USE_FLAT_CONFIG=false eslint .",
-    "lint:eslint:fix": "ESLINT_USE_FLAT_CONFIG=false eslint . --fix",
+    "lint:eslint": "eslint .",
+    "lint:eslint:fix": "eslint . --fix",
     "lint:fix": "pnpm lint:prettier:fix && pnpm lint:eslint:fix",
     "lint:prettier": "prettier -c .",
     "lint:prettier:fix": "prettier . --write",
@@ -30,6 +31,7 @@
   "devDependencies": {
     "@changesets/changelog-github": "^0.5.0",
     "@changesets/cli": "^2.27.10",
+    "@eslint/js": "^9.16.0",
     "@theguild/eslint-config": "0.13.1",
     "@theguild/prettier-config": "3.0.0",
     "@types/node": "^22.10.1",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/website/package.json b/website/package.json
@@ -7,7 +7,7 @@
     "build": "tsc && vite build",
     "clean": "rimraf ./dist",
     "dev": "vite",
-    "lint": "ESLINT_USE_FLAT_CONFIG=false eslint . --report-unused-disable-directives",
+    "lint": "eslint . --report-unused-disable-directives",
     "prebuild": "tsr generate",
     "preview": "vite preview"
   },
diff --git a/website/src/components/Dropzone.tsx b/website/src/components/Dropzone.tsx
@@ -13,7 +13,7 @@ const ACCEPTED_IMAGE_TYPES = {
 };
 
 // Limit avatar images to 1mb
-const MAX_IMAGE_SIZE = 1000000;
+const MAX_IMAGE_SIZE = 1_000_000;
 
 const BOX_SIZE = 152;
 
diff --git a/website/src/components/ui/form.tsx b/website/src/components/ui/form.tsx
@@ -105,7 +105,7 @@ const FormControl = React.forwardRef<
     <Slot
       ref={ref}
       id={formItemId}
-      aria-describedby={!error ? `${formDescriptionId}` : `${formDescriptionId} ${formMessageId}`}
+      aria-describedby={error ? `${formDescriptionId} ${formMessageId}` : formDescriptionId}
       aria-invalid={!!error}
       {...props}
     />
diff --git a/website/src/components/ui/input.tsx b/website/src/components/ui/input.tsx
@@ -1,7 +1,7 @@
 import * as React from 'react';
 import { cn } from '@/lib/utils';
 
-export interface InputProps extends React.InputHTMLAttributes<HTMLInputElement> {}
+type InputProps = React.InputHTMLAttributes<HTMLInputElement>;
 
 const Input = React.forwardRef<HTMLInputElement, InputProps>(
   ({ className, type, ...props }, ref) => {
diff --git a/website/src/components/ui/textarea.tsx b/website/src/components/ui/textarea.tsx
@@ -1,7 +1,7 @@
 import * as React from 'react';
 import { cn } from '@/lib/utils';
 
-export interface TextareaProps extends React.TextareaHTMLAttributes<HTMLTextAreaElement> {}
+type TextareaProps = React.TextareaHTMLAttributes<HTMLTextAreaElement>;
 
 const Textarea = React.forwardRef<HTMLTextAreaElement, TextareaProps>(
   ({ className, ...props }, ref) => {
diff --git a/website/src/components/ui/toaster.tsx b/website/src/components/ui/toaster.tsx
@@ -13,7 +13,7 @@ export function Toaster() {
 
   return (
     <ToastProvider>
-      {toasts.map(function ({ id, title, description, action, ...props }) {
+      {toasts.map(({ id, title, description, action, ...props }) => {
         return (
           <Toast key={id} {...props}>
             <div className="grid gap-1">
diff --git a/website/src/components/ui/use-toast.ts b/website/src/components/ui/use-toast.ts
@@ -3,7 +3,7 @@ import * as React from 'react';
 import type { ToastActionElement, ToastProps } from '@/components/ui/toast';
 
 const TOAST_LIMIT = 1;
-const TOAST_REMOVE_DELAY = 1000000;
+const TOAST_REMOVE_DELAY = 1_000_000;
 
 type ToasterToast = ToastProps & {
   id: string;
@@ -12,12 +12,12 @@ type ToasterToast = ToastProps & {
   action?: ToastActionElement;
 };
 
-const actionTypes = {
-  ADD_TOAST: 'ADD_TOAST',
-  UPDATE_TOAST: 'UPDATE_TOAST',
-  DISMISS_TOAST: 'DISMISS_TOAST',
-  REMOVE_TOAST: 'REMOVE_TOAST',
-} as const;
+type ActionType = {
+  ADD_TOAST: 'ADD_TOAST';
+  UPDATE_TOAST: 'UPDATE_TOAST';
+  DISMISS_TOAST: 'DISMISS_TOAST';
+  REMOVE_TOAST: 'REMOVE_TOAST';
+};
 
 let count = 0;
 
@@ -26,8 +26,6 @@ function genId() {
   return count.toString();
 }
 
-type ActionType = typeof actionTypes;
-
 type Action =
   | {
       type: ActionType['ADD_TOAST'];
@@ -61,7 +59,7 @@ const addToRemoveQueue = (toastId: string) => {
     toastTimeouts.delete(toastId);
     dispatch({
       type: 'REMOVE_TOAST',
-      toastId: toastId,
+      toastId,
     });
   }, TOAST_REMOVE_DELAY);
 
@@ -90,9 +88,9 @@ export const reducer = (state: State, action: Action): State => {
       if (toastId) {
         addToRemoveQueue(toastId);
       } else {
-        state.toasts.forEach(toast => {
+        for (const toast of state.toasts) {
           addToRemoveQueue(toast.id);
-        });
+        }
       }
 
       return {
@@ -127,9 +125,9 @@ let memoryState: State = { toasts: [] };
 
 function dispatch(action: Action) {
   memoryState = reducer(memoryState, action);
-  listeners.forEach(listener => {
+  for (const listener of listeners) {
     listener(memoryState);
-  });
+  }
 }
 
 type Toast = Omit<ToasterToast, 'id'>;
@@ -157,7 +155,7 @@ function toast({ ...props }: Toast) {
   });
 
   return {
-    id: id,
+    id,
     dismiss,
     update,
   };
diff --git a/website/src/routes/publish.lazy.tsx b/website/src/routes/publish.lazy.tsx
@@ -6,8 +6,8 @@ import { Address } from 'viem';
 import { useAccount, useSwitchChain, useWriteContract } from 'wagmi';
 import yaml from 'yaml';
 import { z } from 'zod';
-import { SubgraphImageDropZone } from '@/components/Dropzone';
-import { Editor } from '@/components/Editor';
+import { SubgraphImageDropZone } from '@/components/dropzone';
+import { Editor } from '@/components/editor';
 import { Button } from '@/components/ui/button';
 import {
   Form,
@@ -38,18 +38,18 @@ import { ipfsHexHash } from '@/lib/utils';
 import { zodResolver } from '@hookform/resolvers/zod';
 import { useQuery } from '@tanstack/react-query';
 import { createLazyFileRoute } from '@tanstack/react-router';
-import { L2GNSABI } from '../abis/L2GNS';
+import { L2GNSABI } from '../abis/l2gns';
 import addresses from '../addresses.json';
 
 const SUPPORTED_CHAIN = {
   'arbitrum-one': {
-    chainId: 42161,
-    contracts: addresses[42161],
+    chainId: 42_161,
+    contracts: addresses[42_161],
     subgraph: NETWORK_SUBGRAPH_MAINNET,
   },
   'arbitrum-sepolia': {
-    chainId: 421614,
-    contracts: addresses[421614],
+    chainId: 421_614,
+    contracts: addresses[421_614],
     subgraph: NETWORK_SUBGRAPH_SEPOLIA,
   },
 } as const;
@@ -60,9 +60,9 @@ const getChainInfo = (chain: keyof typeof SUPPORTED_CHAIN) => {
 
 const publishToCopy = (chain: ReturnType<typeof getChainInfo>['chainId']) => {
   switch (chain) {
-    case 42161:
+    case 42_161:
       return 'The Graph Network';
-    case 421614:
+    case 421_614:
       return 'The Graph Testnet (not meant for production workload)';
   }
 };
@@ -390,16 +390,17 @@ function DeploySubgraph({
         toast({
           description: 'You are all set! You can go back to the CLI and close this window',
         });
-      } catch (err) {
+      } catch (_) {
         const e = contractError;
-        if (e?.name === 'ContractFunctionExecutionError') {
-          if (e.cause.name === 'ContractFunctionRevertedError') {
-            toast({
-              description: e.cause.message,
-              variant: 'destructive',
-            });
-            return;
-          }
+        if (
+          e?.name === 'ContractFunctionExecutionError' &&
+          e.cause.name === 'ContractFunctionRevertedError'
+        ) {
+          toast({
+            description: e.cause.message,
+            variant: 'destructive',
+          });
+          return;
         }
 
         toast({
diff --git a/website/tailwind.config.js b/website/tailwind.config.js
@@ -1,6 +1,8 @@
-/* eslint-disable no-undef */
 /** @type {import('tailwindcss').Config} */
-module.exports = {
+
+import animate from 'tailwindcss-animate';
+
+export default {
   darkMode: ['class'],
   content: [
     './pages/**/*.{ts,tsx}',
@@ -74,5 +76,5 @@ module.exports = {
       },
     },
   },
-  plugins: [require('tailwindcss-animate')],
+  plugins: [animate],
 };
diff --git a/website/vite.config.ts b/website/vite.config.ts
@@ -1,4 +1,4 @@
-import path from 'path';
+import path from 'node:path';
 import { defineConfig } from 'vite';
 import { nodePolyfills } from 'vite-plugin-node-polyfills';
 import { TanStackRouterVite } from '@tanstack/router-vite-plugin';
