Update TODO items and fix rules for eslint

- Add `node:` prefix for built-in modules
- Fix `@typescript-eslint/no-this-alias` rule
- Remove `eager_offset.ts`

Author: 0237h

.eslintrc.cjs

@@ -9,22 +9,17 @@ module.exports = {
     'packages/cli/tests/cli/validation',
     'packages/ts/test/',
     'examples',
-    'cf-pages/*',
-    'vitest.config.ts',
+    'vitest.config.ts'
   ],
   rules: {
     // not necessary here, we dont build with bob
     'import/extensions': 'off',
     // pushing to array multiple times is not a big deal
     'unicorn/no-array-push-push': 'off',
-    // TODO: warning for now, clean up
-    '@typescript-eslint/no-this-alias': 'warn',
     // TODO: remove default exports, breaking change?
     'import/no-default-export': 'off',
     // TODO: remove once we get rid of all anys
     '@typescript-eslint/no-explicit-any': 'off',
-    // TODO: not ready yet
-    'unicorn/prefer-node-protocol': 'off',
     '@typescript-eslint/ban-types': 'off',
     // AssemblyScript `===` is a reference equality check, not a value equality check. We are trying to do a value check. Learn more: https://github.com/AssemblyScript/assemblyscript/issues/621#issuecomment-497973428
     eqeqeq: 'off',
@@ -36,12 +31,8 @@ module.exports = {
       rules: {
         // TODO: want to avoid any structural change so fix it later
         '@typescript-eslint/no-namespace': 'off',
-        // TODO: warning for now, clean up
-        'unicorn/filename-case': 'warn',
-        // TODO: warning for now, clean up
-        'sonarjs/no-inverted-boolean-check': 'warn',
-        // TODO: warning for now, clean up
-        '@typescript-eslint/no-loss-of-precision': 'warn',
+        // Some operator depend on the implementation of others, prevent recursion
+        'sonarjs/no-inverted-boolean-check': 'off',
         'no-loss-of-precision': 'warn',
         // AssemblyScript types are different from TS and in cases we want to use what TS may think we should not,
       },

.prettierignore

@@ -6,5 +6,4 @@ packages/cli/tests/cli/init
 packages/cli/tests/cli/validation
 packages/cli/tests/cli/add
 pnpm-lock.yaml
-cf-pages/**
 website/src/graphql-env.d.ts

packages/cli/src/codegen/schema.test.ts

@@ -1,4 +1,4 @@
-import assert from 'assert';
+import assert from 'node:assert';
 import * as graphql from 'graphql/language/index.js';
 import prettier from 'prettier';
 import { describe, expect, test } from 'vitest';

packages/cli/src/command-helpers/auth.ts

@@ -1,6 +1,6 @@
-import fs from 'fs';
-import os from 'os';
-import path from 'path';
+import fs from 'node:fs';
+import os from 'node:os';
+import path from 'node:path';
 import * as toolbox from 'gluegun';
 import { normalizeNodeUrl } from './node.js';
 

packages/cli/src/command-helpers/compiler.ts

@@ -1,4 +1,4 @@
-import { URL } from 'url';
+import { URL } from 'node:url';
 import * as toolbox from 'gluegun';
 import Compiler from '../compiler/index.js';
 import { GRAPH_CLI_SHARED_HEADERS } from '../constants.js';

packages/cli/src/command-helpers/fs.ts

@@ -1,4 +1,4 @@
-import path from 'path';
+import path from 'node:path';
 
 const displayPath = (p: string) => path.relative(process.cwd(), p);
 

packages/cli/src/command-helpers/network.test.ts

@@ -1,4 +1,4 @@
-import path from 'path';
+import path from 'node:path';
 import * as toolbox from 'gluegun';
 import { afterAll, beforeAll, describe, expect, test } from 'vitest';
 import yaml from 'yaml';

packages/cli/src/command-helpers/network.ts

@@ -1,4 +1,4 @@
-import path from 'path';
+import path from 'node:path';
 import { filesystem, patching } from 'gluegun';
 import yaml from 'yaml';
 import { step, withSpinner } from './spinner.js';

packages/cli/src/command-helpers/node.ts

@@ -1,4 +1,4 @@
-import { URL } from 'url';
+import { URL } from 'node:url';
 import { print } from 'gluegun';
 
 export const SUBGRAPH_STUDIO_URL = 'https://api.studio.thegraph.com/deploy/';

packages/cli/src/command-helpers/scaffold.ts

@@ -1,4 +1,4 @@
-import path from 'path';
+import path from 'node:path';
 import fs from 'fs-extra';
 import { strings } from 'gluegun';
 import { Map } from 'immutable';