Skip to content

Commit 971c81a

Browse files
revert log.critical() never return (#2056)
1 parent 2cb827a commit 971c81a

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

.changeset/old-times-double.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

packages/ts/index.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,8 @@ export namespace log {
101101
* @param msg Format string a la "Value = {}, other = {}".
102102
* @param args Format string arguments.
103103
*/
104-
export function critical(msg: string, args: Array<string>): never {
105-
const message = format(msg, args);
106-
log(Level.CRITICAL, message);
107-
throw new Error(message);
104+
export function critical(msg: string, args: Array<string>): void {
105+
log(Level.CRITICAL, format(msg, args));
108106
}
109107

110108
/**

0 commit comments

Comments
 (0)