abi: Fix validating call handlers for functions with tuple params (#500)

Author: Jannis

src/abi.js

@@ -108,7 +108,7 @@ module.exports = class ABI {
         const name = entry.get('name', '<default>')
         const inputs = entry
           .get('inputs', immutable.List())
-          .map(input => input.get('type'))
+          .map(input => buildSignatureParameter(input))
 
         return `${name}(${inputs.join(',')})`
       })

tests/cli/validation.test.js

@@ -39,6 +39,14 @@ describe('Validation', () => {
       exitCode: 1,
     },
   )
+  cliTest(
+    'Call handler with tuple',
+    ['codegen', '--skip-migrations'],
+    'validation/call-handler-with-tuple',
+    {
+      exitCode: 0,
+    },
+  )
   cliTest(
     'Missing entity "id" field',
     ['codegen', '--skip-migrations'],

tests/cli/validation/call-handler-with-tuple.stderr

@@ -0,0 +1,24 @@
+- Load subgraph from subgraph.yaml
+✔ Load subgraph from subgraph.yaml
+- Load contract ABIs
+  Load contract ABI from Abi.json
+- Load contract ABIs
+✔ Load contract ABIs
+- Generate types for contract ABIs
+  Generate types for contract ABI: ExampleContract (Abi.json)
+- Generate types for contract ABIs
+  Write types to generated/ExampleSubgraph/ExampleContract.ts
+- Generate types for contract ABIs
+✔ Generate types for contract ABIs
+- Generate types for data source templates
+✔ Generate types for data source templates
+- Load data source template ABIs
+✔ Load data source template ABIs
+- Generate types for data source template ABIs
+✔ Generate types for data source template ABIs
+- Load GraphQL schema from schema.graphql
+✔ Load GraphQL schema from schema.graphql
+- Generate types for GraphQL schema
+  Write types to generated/schema.ts
+- Generate types for GraphQL schema
+✔ Generate types for GraphQL schema

tests/cli/validation/call-handler-with-tuple/Abi.json

@@ -0,0 +1,24 @@
+[
+  {
+    "constant": false,
+    "inputs": [
+      { "name": "", "type": "uint256" },
+      {
+        "type": "tuple",
+        "components": [
+          { "type": "bytes32" },
+          { "type": "bytes32" },
+          { "type": "uint256" }
+        ]
+      },
+      {
+        "type": "bool"
+      }
+    ],
+    "name": "doSomething",
+    "outputs": [],
+    "payable": false,
+    "stateMutability": "nonpayable",
+    "type": "function"
+  }
+]

tests/cli/validation/call-handler-with-tuple/mapping.ts

@@ -0,0 +1,3 @@
+type MyEntity @entity {
+  id: ID!
+}

tests/cli/validation/call-handler-with-tuple/schema.graphql

@@ -0,0 +1,22 @@
+specVersion: 0.0.2
+schema:
+  file: ./schema.graphql
+dataSources:
+  - kind: ethereum/contract
+    name: ExampleSubgraph
+    source:
+      address: '22843e74c59580b3eaf6c233fa67d8b7c561a835'
+      abi: ExampleContract
+    mapping:
+      kind: ethereum/events
+      apiVersion: 0.0.1
+      language: wasm/assemblyscript
+      file: ./mapping.ts
+      entities:
+        - ExampleEntity
+      abis:
+        - name: ExampleContract
+          file: ./Abi.json
+      callHandlers:
+        - function: doSomething(uint256,(bytes32,bytes32,uint256),bool)
+          handler: handleDoSomething