Skip to content

Commit a4e2e7c

Browse files
committed
don't rename fields themselves, only functions
1 parent d709ae4 commit a4e2e7c

File tree

1 file changed

+13
-8
lines changed

1 file changed

+13
-8
lines changed

packages/cli/src/codegen/schema.ts

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,8 @@ export default class SchemaCodeGenerator {
308308

309309
_generateEntityFieldGetter(_entityDef: ObjectTypeDefinitionNode, fieldDef: FieldDefinitionNode) {
310310
const isDerivedField = this._isDerivedField(fieldDef);
311-
const name = util.handleReservedWord(fieldDef.name.value);
311+
const name = fieldDef.name.value;
312+
const safeName = util.handleReservedWord(name);
312313

313314
if (isDerivedField) {
314315
schemaCodeGeneratorDebug.extend('_generateEntityFieldGetter')(
@@ -340,7 +341,7 @@ export default class SchemaCodeGenerator {
340341
}`;
341342

342343
return tsCodegen.method(
343-
`get ${name}`,
344+
`get ${safeName}`,
344345
[],
345346
returnType,
346347
`
@@ -351,7 +352,9 @@ export default class SchemaCodeGenerator {
351352
}
352353
_generateDerivedFieldGetter(entityDef: ObjectTypeDefinitionNode, fieldDef: FieldDefinitionNode) {
353354
const entityName = entityDef.name.value;
354-
const name = util.handleReservedWord(fieldDef.name.value);
355+
const name = fieldDef.name.value;
356+
const safeName = util.handleReservedWord(name);
357+
355358
schemaCodeGeneratorDebug.extend('_generateDerivedFieldGetter')(
356359
`Generating derived field '${name}' getter for Entity '${entityName}'`,
357360
);
@@ -391,7 +394,7 @@ export default class SchemaCodeGenerator {
391394
const toValueString = idIsBytes ? '.toBytes().toHexString()' : '.toString()';
392395

393396
return tsCodegen.method(
394-
`get ${name}`,
397+
`get ${safeName}`,
395398
[],
396399
returnType,
397400
`
@@ -415,7 +418,8 @@ export default class SchemaCodeGenerator {
415418
_entityDef: ObjectTypeDefinitionNode,
416419
fieldDef: FieldDefinitionNode,
417420
) {
418-
const name = util.handleReservedWord(fieldDef.name.value);
421+
const name = fieldDef.name.value;
422+
const safeName = util.handleReservedWord(name);
419423
const gqlType = fieldDef.type;
420424
const fieldValueType = this._valueTypeFromGraphQl(gqlType);
421425
const returnType = this._typeFromGraphQl(gqlType);
@@ -429,7 +433,7 @@ export default class SchemaCodeGenerator {
429433
}`;
430434

431435
return tsCodegen.method(
432-
`get ${name}`,
436+
`get ${safeName}`,
433437
[],
434438
returnType,
435439
`
@@ -439,7 +443,8 @@ export default class SchemaCodeGenerator {
439443
);
440444
}
441445
_generateEntityFieldSetter(_entityDef: ObjectTypeDefinitionNode, fieldDef: FieldDefinitionNode) {
442-
const name = util.handleReservedWord(fieldDef.name.value);
446+
const name = fieldDef.name.value;
447+
const safeName = util.handleReservedWord(name);
443448
const isDerivedField = !!fieldDef.directives?.find(
444449
directive => directive.name.value === 'derivedFrom',
445450
);
@@ -478,7 +483,7 @@ Suggestion: add an '!' to the member type of the List, change from '[${baseType}
478483
`;
479484

480485
return tsCodegen.method(
481-
`set ${name}`,
486+
`set ${safeName}`,
482487
[tsCodegen.param('value', paramType)],
483488
undefined,
484489
isNullable ? setNullable : setNonNullable,

0 commit comments

Comments
 (0)