Skip to content

Conversation

@joshuanazareth97
Copy link
Contributor

@joshuanazareth97 joshuanazareth97 commented Apr 26, 2024

Change Description

  • Allow passing a file url for spkg files instead of just a file path.
  • Download the file if a url has been passed

Related Issue / Discussion

#1641

Screenshot of change

image
image
image

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2024

🦋 Changeset detected

Latest commit: 7d24759

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphprotocol/graph-cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshuanazareth97 joshuanazareth97 changed the title Feature | Add support to download spkg files from spkg.io Feature | graph init Add support to download spkg files from spkg.io Apr 26, 2024
@joshuanazareth97
Copy link
Contributor Author

Hi @saihaj can you please review this PR? Let me know if there's anything you need me to do before you merge it. Thanks!

@saihaj
Copy link
Contributor

saihaj commented May 2, 2024

thanks @joshuanazareth97 sorry for the delay. I was away on vacation last week, catching up on things will try to land this early next week

Copy link
Contributor

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor nits, thanks for adding tests!

(sorry for the delayed review)

Co-authored-by: Saihajpreet Singh <[email protected]>
@saihaj
Copy link
Contributor

saihaj commented May 15, 2024

@joshuanazareth97 are you still working on this?

@joshuanazareth97
Copy link
Contributor Author

@joshuanazareth97 are you still working on this?

@saihaj apologies, was occupied with some other stuff last week. Have addressed all your comments.

@joshuanazareth97
Copy link
Contributor Author

@saihaj is there anything else you need me to do here? Can we merge this PR if the changes are made to your satisfaction?

@joshuanazareth97 joshuanazareth97 requested a review from saihaj May 29, 2024 11:08
@YaroShkvorets
Copy link
Collaborator

Implemented in #1788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants