Skip to content

Conversation

@0237h
Copy link
Collaborator

@0237h 0237h commented Nov 11, 2024

screenshot_2024-11-11_12-15-34

  • Error message now shows within CLI interactive session instead of error crash
  • Passing --abi will correctly pre-fill the interactive form
  • Catch JSON parsing exception for EthereumABI.

Closes: #1765

@0237h 0237h requested a review from YaroShkvorets November 11, 2024 17:16
@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: 7bf1706

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphprotocol/graph-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

- Error message now shows within CLI interactive session instead of
  error crash
- Passing `--abi` will correctly pre-fill the interactive form
- Catch JSON parsing exception for `EthereumABI`.

Closes: graphprotocol#1765
@0237h 0237h force-pushed the fix/abi-file-verification branch from 60b4323 to 7bf1706 Compare November 11, 2024 17:16
Copy link
Collaborator

@YaroShkvorets YaroShkvorets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

works with SPKG files too

@0237h 0237h merged commit d2fda94 into graphprotocol:main Nov 12, 2024
9 checks passed
@0237h 0237h deleted the fix/abi-file-verification branch November 12, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle non-existing files better

2 participants