Skip to content

Improve call-to-action message for non-existing chain #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Improve call-to-action message for non-existing chain #1842

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0d9d7f
improve call-to-action message for non-existing chain
YaroShkvorets Dec 16, 2024
dcf24e8
lint
YaroShkvorets Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions packages/cli/src/commands/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ async function processInitForm(
if (remaining == 0) return shown;
if (shown.length === choices.length) {
shown.push({
name: '--other--',
name: 'N/A',
value: '',
hint: '· other network not on the list',
message: `Other`,
Expand Down Expand Up @@ -485,15 +485,21 @@ async function processInitForm(
.map(networkToChoice)
.filter(({ value }) => (value ?? '').includes(input.toLowerCase())),
),
validate: value => {
if (value === '--other--') {
return 'To add a network refer to https://github.com/graphprotocol/networks-registry';
}
return networks.find(n => n.id === value) ? true : 'Pick a network';
},
validate: value =>
value === 'N/A' || networks.find(n => n.id === value) ? true : 'Pick a network',
result: value => {
initDebugger.extend('processInitForm')('networkId: %O', value);
network = networks.find(n => n.id === value)!;
const foundNetwork = networks.find(n => n.id === value);
if (!foundNetwork) {
this.log(`
The chain list is populated from the Networks Registry:

https://github.com/graphprotocol/networks-registry

To add a chain to the registry you can create an issue or submit a PR`);
process.exit(0);
}
network = foundNetwork;
promptManager.setOptions('protocol', {
choices: [
{
Expand Down
Loading