Skip to content

Commit 48aa23a

Browse files
committed
feat(separate react): updates from code review. remove react-query from events app
1 parent dd7181b commit 48aa23a

File tree

5 files changed

+7
-55
lines changed

5 files changed

+7
-55
lines changed

apps/events/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
"@radix-ui/react-avatar": "^1.1.2",
1919
"@radix-ui/react-icons": "^1.3.2",
2020
"@radix-ui/react-slot": "^1.1.1",
21-
"@tanstack/react-query": "^5.64.1",
22-
"@tanstack/react-query-devtools": "^5.64.1",
2321
"@tanstack/react-router": "^1.97.1",
2422
"@xstate/store": "^2.6.2",
2523
"class-variance-authority": "^0.7.1",

apps/events/src/components/todos.tsx

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,9 @@ import { Input } from './ui/input';
88

99
export const Todos = () => {
1010
const todos = Space.useQueryEntities(Todo);
11-
const createEntity = Space.useCreateEntity(Todo, {
12-
throwOnError(error) {
13-
console.error(error);
14-
return true;
15-
},
16-
});
11+
const createEntity = Space.useCreateEntity(Todo);
1712
const updateEntity = Space.useUpdateEntity(Todo);
18-
const deleteEntity = Space.useDeleteEntity(Todo);
13+
const deleteEntity = Space.useDeleteEntity();
1914
const [newTodoTitle, setNewTodoTitle] = useState('');
2015

2116
return (
@@ -25,23 +20,22 @@ export const Todos = () => {
2520
<Input type="text" value={newTodoTitle} onChange={(e) => setNewTodoTitle(e.target.value)} />
2621
<Button
2722
onClick={() => {
28-
createEntity.mutate({ name: newTodoTitle, completed: false });
23+
createEntity({ name: newTodoTitle, completed: false });
2924
setNewTodoTitle('');
3025
}}
3126
>
3227
Create Todo
3328
</Button>
34-
<div>{JSON.stringify(createEntity.error ?? {})}</div>
3529
</div>
36-
{(todos.data ?? []).map((todo) => (
30+
{(todos ?? []).map((todo) => (
3731
<div key={todo.id} className="flex flex-row items-center gap-2">
3832
<h2>{todo.name}</h2>
3933
<input
4034
type="checkbox"
4135
checked={todo.completed}
42-
onChange={(e) => updateEntity.mutate({ id: todo.id, data: { completed: e.target.checked } })}
36+
onChange={(e) => updateEntity({ id: todo.id, data: { completed: e.target.checked } })}
4337
/>
44-
<Button onClick={() => deleteEntity.mutate({ id: todo.id })}>Delete</Button>
38+
<Button onClick={() => deleteEntity(todo.id)}>Delete</Button>
4539
</div>
4640
))}
4741
</>

apps/events/src/routes/space/$spaceId.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { store } from '@graphprotocol/hypergraph';
22
import { Hypergraph, Space as HypergraphSpace } from '@graphprotocol/hypergraph-react';
3-
import { ReactQueryDevtools } from '@tanstack/react-query-devtools';
43
import { createFileRoute } from '@tanstack/react-router';
54
import { useSelector } from '@xstate/store/react';
65

@@ -60,7 +59,6 @@ function Space() {
6059
<div className="mt-12">
6160
<DevTool spaceId={spaceId} />
6261
</div>
63-
<ReactQueryDevtools />
6462
</HypergraphSpace.HypergraphSpaceProvider>
6563
</div>
6664
);

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"private": true,
33
"type": "module",
4-
"packageManager": "pnpm@9.14.4",
4+
"packageManager": "pnpm@9.15.4",
55
"workspaces": ["apps/*", "packages/*"],
66
"scripts": {
77
"clean": "node scripts/clean.mjs",

pnpm-lock.yaml

Lines changed: 0 additions & 38 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)