Skip to content

Conversation

nikgraf
Copy link
Collaborator

@nikgraf nikgraf commented Feb 12, 2025

No description provided.

@nikgraf nikgraf self-assigned this Feb 12, 2025
@nikgraf nikgraf force-pushed the ng/upgrade-pnpm branch 2 times, most recently from 7719893 to 33a04df Compare February 12, 2025 12:40
@nikgraf
Copy link
Collaborator Author

nikgraf commented Feb 12, 2025

@fubhy pnpm 10 requires inject-workspace-packages set to true or we deploy with --legacy. What's your preference?

@nikgraf nikgraf requested a review from fubhy February 17, 2025 11:21
@fubhy
Copy link
Member

fubhy commented Feb 17, 2025

I just read some threads in the pnpm repository. Sounds like --legacy is the less risky option for now.

Co-authored-by: Sebastian Lorenz <[email protected]>
@nikgraf nikgraf requested a review from fubhy February 17, 2025 13:28
@fubhy fubhy merged commit 4250403 into main Feb 17, 2025
4 checks passed
@fubhy fubhy deleted the ng/upgrade-pnpm branch February 17, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants