server tracing #420
server tracing #420
Conversation
nikgraf
force-pushed
the
ng/server-tracing
branch
from
2367913 to
527fbda
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request adds development infrastructure and server tracing capabilities to support the hypergraph project. The main focus is on upgrading the Effect library to version 3.17.9 and introducing a new server implementation with comprehensive tracing support.
- Effect library updated from 3.17.8 to 3.17.9 across all packages
- Added Effect language server plugin for enhanced TypeScript development experience
- New server implementation (
apps/server-new) with Effect-based architecture and comprehensive API documentation
Reviewed Changes
Copilot reviewed 82 out of 85 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.base.json | Added Effect language service plugin for better TypeScript support |
| package.json | Added Effect language service and vitest packages to development dependencies |
| packages/*/package.json | Updated Effect library from 3.17.8 to 3.17.9 across all packages |
| packages/hypergraph/src/**/types.ts | Refactored error classes to use Data.TaggedError for better Effect integration |
| packages/hypergraph/src/space-events/apply-event.ts | Updated error handling syntax for Effect library compatibility |
| apps/server-new/** | Complete new server implementation with Effect-based architecture, services, and API documentation |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
|
|
||
| // find the invitation | ||
| const result = Object.entries(invitations).find( | ||
| ([, invitation]) => invitation.inviteeAccountAddress === event.author.accountAddress, | ||
| ); | ||
| if (!result) { | ||
| yield* Effect.fail(new InvalidEventError()); | ||
| return yield* new InvalidEventError(); |
There was a problem hiding this comment.
Incorrect syntax for Effect error handling. All instances should use yield* Effect.fail(new InvalidEventError()) instead of return yield* new InvalidEventError().
| return yield* new InvalidEventError(); | |
| return yield* Effect.fail(new InvalidEventError()); |
Copilot uses AI. Check for mistakes.
| @@ -112,11 +111,11 @@ export const applyEvent = ({ | |||
| invitations = {}; | |||
| } else if (event.transaction.type === 'create-invitation') { | |||
| if (members[event.transaction.inviteeAccountAddress] !== undefined) { | |||
| yield* Effect.fail(new InvalidEventError()); | |||
| return yield* new InvalidEventError(); | |||
There was a problem hiding this comment.
Incorrect syntax for Effect error handling. All instances should use yield* Effect.fail(new InvalidEventError()) instead of return yield* new InvalidEventError().
| return yield* new InvalidEventError(); | |
| return yield* Effect.fail(new InvalidEventError()); |
Copilot uses AI. Check for mistakes.
created follow up issues here:
merging since we had useful changes like the effect language server