Improves the build setup #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nikgraf
commented
Nov 26, 2024
nikgraf
commented
- Use paths and references to directly use the src files during development (requires bun for the server)
- Improves vitest setup
cmwhited
reviewed
Nov 26, 2024
| { "path": "packages/graph-framework-utils" }, | ||
| { "path": "packages/graph-framework-messages" }, | ||
| { "path": "packages/graph-framework-key" }, | ||
| { "path": "apps/events" } |
There was a problem hiding this comment.
Do we need this reference?
nikgraf
force-pushed
the
nik/build-setup
branch
from
e8e2910 to
4d36e80
Compare
cmwhited
approved these changes
Nov 26, 2024
| "scripts": { | ||
| "dev": "vite --force", | ||
| "build": "tsc -b && vite build", | ||
| "build": "echo 'TODO'", |
There was a problem hiding this comment.
Can we not do the tsc -b && vite build?
There was a problem hiding this comment.
currently it's broken. Mentioned it also here: #56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.