Skip to content

Commit 15c83d9

Browse files
suchapalaverclaude
andcommitted
fix(tap-agent): resolve V2 actor system and collection ID parsing issues
This commit addresses multiple issues that were preventing the V2 TAP actor system from functioning properly: 1. **Actor Race Condition Prevention**: Added existence check in SenderAccount to prevent duplicate actor creation attempts that caused "Actor already registered" errors during concurrent receipt processing. 2. **Collection ID Parsing**: Fixed parsing of collection_id strings from database during migration period: - Handle both 20-byte addresses and 32-byte collection IDs - Proper whitespace trimming and error reporting - Consistent 0x prefix handling for both Address and CollectionId parsing 3. **Attestation Error Messages**: Updated error messages to be factual about what is observed rather than speculative about causes when key derivation fails after testing multiple combinations. 4. **BIP32 Path Length Handling**: Maintained existing v1/v2 fallback system for handling long deployment IDs that exceed BIP32 path limits. The V2 TAP actor system now starts successfully and can process receipts. RAV generation is pending allocation closure in the test environment. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent d662e43 commit 15c83d9

File tree

8 files changed

+450
-11
lines changed

8 files changed

+450
-11
lines changed

Cargo.lock

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

contrib/indexer-service/config.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ status_url = "http://graph-node:8030/graphql"
1111

1212
[subgraphs.network]
1313
query_url = "http://graph-node:8000/subgraphs/name/graph-network"
14-
deployment_id = "NETWORK_DEPLOYMENT_PLACEHOLDER"
1514
syncing_interval_secs = 5
1615
recently_closed_allocation_buffer_secs = 10
1716

crates/attestation/Cargo.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ edition = "2021"
66
[dependencies]
77
anyhow.workspace = true
88
indexer-allocation = { path = "../allocation" }
9+
sha2 = "0.10"
910
thegraph-core.workspace = true
11+
tracing.workspace = true
1012

1113

1214
[dev-dependencies]

0 commit comments

Comments
 (0)