refactor: use router builder (#513)

Author: gusinacio

Cargo.lock

@@ -29,7 +29,11 @@ alloy = { version = "=0.5.4", features = [
 ], default-features = false }
 clap = "4.4.3"
 lazy_static = "1.4.0"
-axum = { version = "0.7.7", default-features = false }
+axum = { version = "0.7.9", default-features = false, features = [
+  "tokio",
+  "http1",
+  "http2",
+] }
 tokio = "1.40"
 prometheus = "0.13.3"
 anyhow = { version = "1.0.72" }
@@ -72,3 +76,5 @@ thegraph-graphql-http = "0.2.0"
 graphql_client = { version = "0.14.0", features = ["reqwest-rustls"] }
 bip39 = "2.0.0"
 rstest = "0.23.0"
+wiremock = "0.6.1"
+typed-builder = "0.20.0"

Cargo.toml

@@ -30,7 +30,7 @@ use crate::NonZeroGRT;
 
 const SHARED_PREFIX: &str = "INDEXER_";
 
-#[derive(Debug, Deserialize, Clone)]
+#[derive(Debug, Deserialize)]
 #[cfg_attr(test, derive(PartialEq))]
 pub struct Config {
     pub indexer: IndexerConfig,
@@ -229,14 +229,14 @@ impl Config {
     }
 }
 
-#[derive(Debug, Deserialize, Clone)]
+#[derive(Debug, Deserialize)]
 #[cfg_attr(test, derive(PartialEq))]
 pub struct IndexerConfig {
     pub indexer_address: Address,
     pub operator_mnemonic: Mnemonic,
 }
 
-#[derive(Clone, Debug, Deserialize)]
+#[derive(Debug, Deserialize, Clone)]
 #[cfg_attr(test, derive(PartialEq))]
 #[serde(untagged)]
 #[serde(deny_unknown_fields)]
@@ -278,14 +278,14 @@ impl DatabaseConfig {
     }
 }
 
-#[derive(Debug, Deserialize, Clone)]
+#[derive(Debug, Deserialize)]
 #[cfg_attr(test, derive(PartialEq))]
 pub struct GraphNodeConfig {
     pub query_url: Url,
     pub status_url: Url,
 }
 
-#[derive(Debug, Deserialize, Clone)]
+#[derive(Debug, Deserialize)]
 #[cfg_attr(test, derive(PartialEq))]
 pub struct MetricsConfig {
     pub port: u16,
@@ -297,15 +297,15 @@ impl MetricsConfig {
     }
 }
 
-#[derive(Debug, Deserialize, Clone)]
+#[derive(Debug, Deserialize)]
 #[cfg_attr(test, derive(PartialEq))]
 pub struct SubgraphsConfig {
     pub network: NetworkSubgraphConfig,
     pub escrow: EscrowSubgraphConfig,
 }
 
 #[serde_as]
-#[derive(Debug, Deserialize, Clone)]
+#[derive(Debug, Deserialize)]
 #[cfg_attr(test, derive(PartialEq))]
 pub struct NetworkSubgraphConfig {
     #[serde(flatten)]
@@ -315,15 +315,15 @@ pub struct NetworkSubgraphConfig {
     pub recently_closed_allocation_buffer_secs: Duration,
 }
 
-#[derive(Debug, Deserialize, Clone)]
+#[derive(Debug, Deserialize)]
 #[cfg_attr(test, derive(PartialEq))]
 pub struct EscrowSubgraphConfig {
     #[serde(flatten)]
     pub config: SubgraphConfig,
 }
 
 #[serde_as]
-#[derive(Debug, Deserialize, Clone)]
+#[derive(Debug, Deserialize)]
 #[cfg_attr(test, derive(PartialEq))]
 pub struct SubgraphConfig {
     pub query_url: Url,
@@ -346,14 +346,14 @@ pub enum TheGraphChainId {
     Test = 1337,
 }
 
-#[derive(Debug, Deserialize, Clone)]
+#[derive(Debug, Deserialize)]
 #[cfg_attr(test, derive(PartialEq))]
 pub struct BlockchainConfig {
     pub chain_id: TheGraphChainId,
     pub receipts_verifier_address: Address,
 }
 
-#[derive(Debug, Deserialize, Clone)]
+#[derive(Debug, Deserialize)]
 #[cfg_attr(test, derive(PartialEq))]
 pub struct ServiceConfig {
     pub serve_network_subgraph: bool,
@@ -366,14 +366,14 @@ pub struct ServiceConfig {
 }
 
 #[serde_as]
-#[derive(Debug, Deserialize, Clone)]
+#[derive(Debug, Deserialize)]
 #[cfg_attr(test, derive(PartialEq))]
 pub struct ServiceTapConfig {
     /// what's the maximum value we accept in a receipt
     pub max_receipt_value_grt: NonZeroGRT,
 }
 
-#[derive(Debug, Deserialize, Clone)]
+#[derive(Debug, Deserialize)]
 #[cfg_attr(test, derive(PartialEq))]
 pub struct TapConfig {
     /// what is the maximum amount the indexer is willing to lose in grt
@@ -383,7 +383,7 @@ pub struct TapConfig {
     pub sender_aggregator_endpoints: HashMap<Address, Url>,
 }
 
-#[derive(Debug, Deserialize, Clone)]
+#[derive(Debug, Deserialize)]
 #[cfg_attr(test, derive(PartialEq))]
 pub struct DipsConfig {
     pub allowed_payers: Vec<Address>,
@@ -402,7 +402,7 @@ impl TapConfig {
 }
 
 #[serde_as]
-#[derive(Debug, Deserialize, Clone)]
+#[derive(Debug, Deserialize)]
 #[cfg_attr(test, derive(PartialEq))]
 pub struct RavRequestConfig {
     /// what divisor of the amount willing to lose to trigger the rav request

crates/config/src/config.rs

@@ -24,5 +24,5 @@ bip39.workspace = true
 [dev-dependencies]
 env_logger = { version = "0.11.0", default-features = false }
 test-log = { version = "0.2.12", default-features = false }
-wiremock = "0.5.19"
+wiremock.workspace = true
 test-assets = { path = "../test-assets" }

crates/monitor/Cargo.toml

@@ -12,13 +12,16 @@ use std::{
 };
 use tokio::sync::watch::Receiver;
 
+/// Receiver of Map between allocation id and allocation struct
+pub type AllocationWatcher = Receiver<HashMap<Address, Allocation>>;
+
 /// An always up-to-date list of an indexer's active and recently closed allocations.
 pub async fn indexer_allocations(
     network_subgraph: &'static SubgraphClient,
     indexer_address: Address,
     interval: Duration,
     recently_closed_allocation_buffer: Duration,
-) -> anyhow::Result<Receiver<HashMap<Address, Allocation>>> {
+) -> anyhow::Result<AllocationWatcher> {
     new_watcher(interval, move || async move {
         get_allocations(
             network_subgraph,

crates/monitor/src/allocations.rs

@@ -11,13 +11,18 @@ use thegraph_core::{Address, ChainId};
 use tokio::sync::watch::Receiver;
 use tracing::warn;
 
+use crate::{AllocationWatcher, DisputeManagerWatcher};
+
+/// Receiver for Map of allocation id and attestation signer
+pub type AttestationWatcher = Receiver<HashMap<Address, AttestationSigner>>;
+
 /// An always up-to-date list of attestation signers, one for each of the indexer's allocations.
 pub fn attestation_signers(
-    indexer_allocations_rx: Receiver<HashMap<Address, Allocation>>,
+    indexer_allocations_rx: AllocationWatcher,
     indexer_mnemonic: Mnemonic,
     chain_id: ChainId,
-    dispute_manager_rx: Receiver<Address>,
-) -> Receiver<HashMap<Address, AttestationSigner>> {
+    dispute_manager_rx: DisputeManagerWatcher,
+) -> AttestationWatcher {
     let attestation_signers_map: &'static Mutex<HashMap<Address, AttestationSigner>> =
         Box::leak(Box::new(Mutex::new(HashMap::new())));
     let indexer_mnemonic = Arc::new(indexer_mnemonic.to_string());

crates/monitor/src/attestation.rs

@@ -26,24 +26,26 @@ impl DeploymentDetails {
         graph_node_base_url: &str,
         deployment: DeploymentId,
     ) -> Result<Self, anyhow::Error> {
-        Self::for_graph_node_url(
+        Ok(Self::for_graph_node_url(
             Url::parse(graph_node_status_url)?,
             Url::parse(graph_node_base_url)?,
             deployment,
-        )
+        ))
     }
 
     pub fn for_graph_node_url(
         graph_node_status_url: Url,
         graph_node_base_url: Url,
         deployment: DeploymentId,
-    ) -> Result<Self, anyhow::Error> {
-        Ok(Self {
+    ) -> Self {
+        Self {
             deployment: Some(deployment),
             status_url: Some(graph_node_status_url),
-            query_url: graph_node_base_url.join(&format!("subgraphs/id/{deployment}"))?,
+            query_url: graph_node_base_url
+                .join(&format!("subgraphs/id/{deployment}"))
+                .expect("Must be correct"),
             query_auth_token: None,
-        })
+        }
     }
 
     pub fn for_query_url(query_url: &str) -> Result<Self, anyhow::Error> {
@@ -55,17 +57,7 @@ impl DeploymentDetails {
         })
     }
 
-    pub fn for_query_url_with_token(
-        query_url: &str,
-        query_auth_token: Option<String>,
-    ) -> Result<Self, anyhow::Error> {
-        Ok(Self::for_query_url_with_token_url(
-            Url::parse(query_url)?,
-            query_auth_token,
-        ))
-    }
-
-    pub fn for_query_url_with_token_url(query_url: Url, query_auth_token: Option<String>) -> Self {
+    pub fn for_query_url_with_token(query_url: Url, query_auth_token: Option<String>) -> Self {
         Self {
             deployment: None,
             status_url: None,

crates/monitor/src/client/subgraph_client.rs

@@ -5,14 +5,18 @@ use std::collections::HashMap;
 use thegraph_core::{Address, DeploymentId};
 use tokio::sync::watch::Receiver;
 
-use indexer_allocation::Allocation;
 use indexer_watcher::map_watcher;
 
+use crate::AllocationWatcher;
+
+/// Watcher for Map of deployment id and allocation id
+pub type DeploymentToAllocationWatcher = Receiver<HashMap<DeploymentId, Address>>;
+
 /// Watcher of indexer allocation
 /// returning a map of subgraph deployment to allocation id
 pub fn deployment_to_allocation(
-    indexer_allocations_rx: Receiver<HashMap<Address, Allocation>>,
-) -> Receiver<HashMap<DeploymentId, Address>> {
+    indexer_allocations_rx: AllocationWatcher,
+) -> DeploymentToAllocationWatcher {
     map_watcher(indexer_allocations_rx, move |allocation| {
         allocation
             .iter()

crates/monitor/src/deployment_to_allocation.rs

@@ -9,10 +9,14 @@ use indexer_watcher::new_watcher;
 use std::time::Duration;
 use tokio::sync::watch::Receiver;
 
+/// Watcher for Dispute Manager Address
+pub type DisputeManagerWatcher = Receiver<Address>;
+
+/// Monitors the subgraph for dispute manager address
 pub async fn dispute_manager(
     network_subgraph: &'static SubgraphClient,
     interval: Duration,
-) -> anyhow::Result<Receiver<Address>> {
+) -> anyhow::Result<DisputeManagerWatcher> {
     new_watcher(interval, move || async move {
         let response = network_subgraph
             .query::<DisputeManager, _>(dispute_manager::Variables {})

crates/monitor/src/dispute_manager.rs

@@ -87,12 +87,14 @@ impl EscrowAccounts {
     }
 }
 
+pub type EscrowAccountsWatcher = Receiver<EscrowAccounts>;
+
 pub async fn escrow_accounts(
     escrow_subgraph: &'static SubgraphClient,
     indexer_address: Address,
     interval: Duration,
     reject_thawing_signers: bool,
-) -> Result<Receiver<EscrowAccounts>, anyhow::Error> {
+) -> Result<EscrowAccountsWatcher, anyhow::Error> {
     indexer_watcher::new_watcher(interval, move || {
         get_escrow_accounts(escrow_subgraph, indexer_address, reject_thawing_signers)
     })