refactor(clippy): fix updated warnings for rust 1.88

Signed-off-by: Joseph Livesey <[email protected]>

Author: suchapalaver

crates/monitor/src/escrow_accounts.rs

@@ -132,7 +132,7 @@ async fn get_escrow_accounts_v2(
 
     let response = escrow_subgraph
         .query::<NetworkEscrowAccountQueryV2, _>(network_escrow_account_v2::Variables {
-            receiver: format!("{:x?}", indexer_address),
+            receiver: format!("{indexer_address:x?}"),
             thaw_end_timestamp: if reject_thawing_signers {
                 U256::ZERO.to_string()
             } else {

crates/tap-agent/src/agent/sender_account.rs

@@ -880,8 +880,8 @@ impl Actor for SenderAccount {
 
                                 match escrow_subgraph
                                     .query::<LatestRavs, _>(latest_ravs_v2::Variables {
-                                        payer: format!("{:x?}", sender_id),
-                                        data_service: format!("{:x?}", data_service),
+                                        payer: format!("{sender_id:x?}"),
+                                        data_service: format!("{data_service:x?}"),
                                         service_provider: format!("{:x?}", config.indexer_address),
                                         collection_ids: collection_ids.clone(),
                                     })

crates/tap-agent/src/agent/sender_accounts_manager.rs

@@ -102,8 +102,8 @@ impl AllocationId {
 impl Display for AllocationId {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self {
-            AllocationId::Legacy(allocation_id) => write!(f, "{}", allocation_id),
-            AllocationId::Horizon(collection_id) => write!(f, "{}", collection_id),
+            AllocationId::Legacy(allocation_id) => write!(f, "{allocation_id}"),
+            AllocationId::Horizon(collection_id) => write!(f, "{collection_id}"),
         }
     }
 }

crates/tap-agent/src/tap/context/receipt.rs

@@ -269,7 +269,7 @@ impl ReceiptRead<TapReceipt> for TapAgentContext<Horizon> {
                 let collection_id = FixedBytes::<32>::from_str(&record.collection_id).map_err(|e| {
                     AdapterError::ReceiptRead {
                         error: format!(
-                            "Error decoding allocation_id while retrieving receipt from database: {e}"
+                            "Error decoding collection_id while retrieving receipt from database: {e}"
                         ),
                     }
                 })?;

integration-tests/src/load_test.rs

@@ -173,35 +173,29 @@ pub async fn receipt_handler_load_test_v2(num_receipts: usize, concurrency: usiz
                 // Check if the send was Ok
                 if let Err(e) = send_result {
                     failed_sends += 1;
-                    eprintln!("V2 Receipt {} failed to send: {:?}", index, e); // Log the specific error
+                    eprintln!("V2 Receipt {index} failed to send: {e:?}"); // Log the specific error
                 } else {
                     successful_sends += 1;
                 }
             }
             Err(join_error) => {
                 // The task panicked or was cancelled
                 failed_sends += 1;
-                eprintln!(
-                    "V2 Receipt {} task execution failed (e.g., panic): {:?}",
-                    index, join_error
-                );
+                eprintln!("V2 Receipt {index} task execution failed (e.g., panic): {join_error:?}");
             }
         }
     }
 
     let duration = start.elapsed();
-    println!(
-        "Completed processing {} V2 requests in {:?}",
-        num_receipts, duration
-    );
+    println!("Completed processing {num_receipts} V2 requests in {duration:?}");
     if num_receipts > 0 {
         println!(
             "Average time per V2 request: {:?}",
             duration / num_receipts as u32
         );
     }
-    println!("Successfully sent V2 receipts: {}", successful_sends);
-    println!("Failed V2 receipts: {}", failed_sends);
+    println!("Successfully sent V2 receipts: {successful_sends}");
+    println!("Failed V2 receipts: {failed_sends}");
 
     if failed_sends > 0 {
         return Err(anyhow::anyhow!(
@@ -233,7 +227,7 @@ async fn create_and_send_receipts_v2(
     let receipt_encoded = encode_v2_receipt(&receipt)?;
     let response = create_request(
         &http_client,
-        format!("{}/subgraphs/id/{}", INDEXER_URL, SUBGRAPH_ID).as_str(),
+        format!("{INDEXER_URL}/subgraphs/id/{SUBGRAPH_ID}").as_str(),
         &receipt_encoded,
         &json!({
             "query": "{ _meta { block { number } } }"

integration-tests/src/rav_tests.rs

@@ -238,8 +238,7 @@ pub async fn test_tap_rav_v2() -> Result<()> {
         initial_metrics.unaggregated_fees_by_allocation(&allocation_id.to_string());
 
     println!(
-        "\n=== V2 Initial metrics: RAVs created: {}, Unaggregated fees: {} ===",
-        initial_ravs_created, initial_unaggregated
+        "\n=== V2 Initial metrics: RAVs created: {initial_ravs_created}, Unaggregated fees: {initial_unaggregated} ==="
     );
 
     println!("\n=== V2 STAGE 1: Sending large receipt batches with small pauses ===");
@@ -270,7 +269,7 @@ pub async fn test_tap_rav_v2() -> Result<()> {
 
             let response = create_request(
                 &http_client,
-                &format!("{}/subgraphs/id/{}", INDEXER_URL, SUBGRAPH_ID),
+                &format!("{INDEXER_URL}/subgraphs/id/{SUBGRAPH_ID}"),
                 &receipt_encoded,
                 &json!({
                     "query": "{ _meta { block { number } } }"
@@ -334,7 +333,7 @@ pub async fn test_tap_rav_v2() -> Result<()> {
 
         let response = create_request(
             &http_client,
-            &format!("{}/subgraphs/id/{}", INDEXER_URL, SUBGRAPH_ID),
+            &format!("{INDEXER_URL}/subgraphs/id/{SUBGRAPH_ID}"),
             &receipt_encoded,
             &json!({
                 "query": "{ _meta { block { number } } }"
@@ -372,23 +371,21 @@ pub async fn test_tap_rav_v2() -> Result<()> {
         // If we've succeeded, exit early
         if current_ravs_created > initial_ravs_created {
             println!(
-                "✅ V2 TEST PASSED: RAVs created increased from {} to {}!",
-                initial_ravs_created, current_ravs_created
+                "✅ V2 TEST PASSED: RAVs created increased from {initial_ravs_created} to {current_ravs_created}!"
             );
             return Ok(());
         }
 
         if current_unaggregated < initial_unaggregated * 0.9 {
             println!(
-                "✅ V2 TEST PASSED: Unaggregated fees decreased significantly from {} to {}!",
-                initial_unaggregated, current_unaggregated
+                "✅ V2 TEST PASSED: Unaggregated fees decreased significantly from {initial_unaggregated} to {current_unaggregated}!"
             );
             return Ok(());
         }
     }
 
     println!("\n=== V2 Summary ===");
-    println!("Total V2 queries sent successfully: {}", total_successful);
+    println!("Total V2 queries sent successfully: {total_successful}");
 
     // If we got here, test failed
     println!("❌ V2 TEST FAILED: No RAV generation detected");