fix: return error instead of panicking if fetching from ipfs fails (#671)

* fix: return error instead of panicking if fetching from ipfs fails

* fix: keep the original error message

* fix: add some logging

* fix: fmt

Author: pcarranzav

Cargo.lock

@@ -17,6 +17,7 @@ async-trait.workspace = true
 uuid.workspace = true
 tokio.workspace = true
 indexer-monitor = { path = "../monitor" }
+tracing.workspace = true
 
 bytes = { version = "1.10.0", optional = true }
 derivative = "2.2.0"

crates/dips/Cargo.toml

@@ -9,6 +9,7 @@ use futures::TryStreamExt;
 use http::Uri;
 use ipfs_api_prelude::{IpfsApi, TryFromUri};
 use serde::Deserialize;
+use tracing;
 
 use crate::DipsError;
 
@@ -50,10 +51,15 @@ impl IpfsFetcher for IpfsClient {
             .map_ok(|chunk| chunk.to_vec())
             .try_concat()
             .await
-            .unwrap();
-
-        let manifest: GraphManifest = serde_yaml::from_slice(&content)
-            .map_err(|_| DipsError::InvalidSubgraphManifest(file.to_string()))?;
+            .map_err(|e| {
+                tracing::warn!("Failed to fetch subgraph manifest {}: {}", file, e);
+                DipsError::SubgraphManifestUnavailable(format!("{}: {}", file, e))
+            })?;
+
+        let manifest: GraphManifest = serde_yaml::from_slice(&content).map_err(|e| {
+            tracing::warn!("Failed to parse subgraph manifest {}: {}", file, e);
+            DipsError::InvalidSubgraphManifest(format!("{}: {}", file, e))
+        })?;
 
         Ok(manifest)
     }

crates/dips/src/ipfs.rs

@@ -139,6 +139,8 @@ pub enum DipsError {
     PayerNotAuthorised(Address),
     #[error("voucher payee {actual} does not match the expected address {expected}")]
     UnexpectedPayee { expected: Address, actual: Address },
+    #[error("cannot get subgraph manifest for {0}")]
+    SubgraphManifestUnavailable(String),
     #[error("invalid subgraph id {0}")]
     InvalidSubgraphManifest(String),
     #[error("voucher for chain id {0}, subgraph manifest has network {1}")]