chore: clear up duplicate code

Author: suchapalaver

crates/tap-agent/src/actor_migrate.rs

@@ -84,24 +84,8 @@ impl<T> Clone for TaskHandle<T> {
 }
 
 impl<T> TaskHandle<T> {
-    /// Create a new task handle for testing
-    #[cfg(any(test, feature = "test"))]
-    pub fn new_for_test(
-        tx: mpsc::Sender<T>,
-        name: Option<String>,
-        lifecycle: Arc<LifecycleManager>,
-    ) -> Self {
-        Self {
-            tx,
-            task_id: TaskId::new(),
-            name,
-            lifecycle,
-        }
-    }
-
-    /// Create a new task handle for production use
-    #[cfg(not(any(test, feature = "test")))]
-    pub fn new_for_production(
+    /// Create a new task handle
+    pub fn new(
         tx: mpsc::Sender<T>,
         name: Option<String>,
         lifecycle: Arc<LifecycleManager>,

crates/tap-agent/src/agent/sender_account_task.rs

@@ -398,7 +398,7 @@ impl SenderAccountTask {
         {
             // Create a self-reference handle for the child to communicate back
             let (self_tx, mut self_rx) = mpsc::channel::<SenderAccountMessage>(10);
-            let self_handle = TaskHandle::new_for_test(
+            let self_handle = TaskHandle::new(
                 self_tx,
                 Some(format!("sender_account_{}", state.sender)),
                 state.lifecycle.clone(),
@@ -482,8 +482,8 @@ impl SenderAccountTask {
             // Create a self-reference handle for the child to communicate back
             let (self_tx, self_rx) = mpsc::channel::<SenderAccountMessage>(10);
 
-            // Create proper TaskHandle for production
-            let self_handle = TaskHandle::new_for_production(
+            // Create TaskHandle for production
+            let self_handle = TaskHandle::new(
                 self_tx,
                 Some(format!("sender_account_{}", state.sender)),
                 state.lifecycle.clone(),

crates/tap-agent/src/agent/sender_allocation_task.rs

@@ -1095,7 +1095,7 @@ mod tests {
 
         // Create a dummy parent handle for testing
         let (parent_tx, mut parent_rx) = mpsc::channel(10);
-        let parent_handle = TaskHandle::new_for_test(
+        let parent_handle = TaskHandle::new(
             parent_tx,
             Some("test_parent".to_string()),
             std::sync::Arc::new(lifecycle.clone()),
@@ -1157,7 +1157,7 @@ mod tests {
 
         // Create a dummy parent handle for testing
         let (parent_tx, mut parent_rx) = mpsc::channel(10);
-        let parent_handle = TaskHandle::new_for_test(
+        let parent_handle = TaskHandle::new(
             parent_tx,
             Some("test_parent".to_string()),
             std::sync::Arc::new(lifecycle.clone()),
@@ -1257,7 +1257,7 @@ mod tests {
 
         // Create a dummy parent handle for testing
         let (parent_tx, mut parent_rx) = mpsc::channel(10);
-        let parent_handle = TaskHandle::new_for_test(
+        let parent_handle = TaskHandle::new(
             parent_tx,
             Some("test_parent".to_string()),
             std::sync::Arc::new(lifecycle.clone()),
@@ -1362,7 +1362,7 @@ mod tests {
 
         // Create a dummy parent handle for testing
         let (parent_tx, mut parent_rx) = mpsc::channel(10);
-        let parent_handle = TaskHandle::new_for_test(
+        let parent_handle = TaskHandle::new(
             parent_tx,
             Some("test_parent".to_string()),
             std::sync::Arc::new(lifecycle.clone()),